Source/web/WebScreenOrientationController.cpp - Issue 132113006: Add initial Blink-side support for the Screen Orientation API

Side by Side Diff: Source/web/WebScreenOrientationController.cpp

Issue 132113006: Add initial Blink-side support for the Screen Orientation API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reupload Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/modules/screen_orientation/testing/ScreenOrientationClientMock.cpp ('K') | « Source/web/ScreenOrientationClientProxy.cpp ('k') | Source/web/WebViewImpl.h » ('j') | public/web/WebScreenOrientation.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "WebScreenOrientationController.h"

	7

	8 #include "modules/screen_orientation/ScreenOrientationController.h"

	9

	10 namespace blink {

	11

	12 // Make sure WebScreenOrientation stays in sync with WebCore::ScreenOrientationV alue.

	13 COMPILE_ASSERT(WebScreenOrientationPortraitPrimary == static_cast<WebScreenOrien tation>(WebCore::OrientationPortraitPrimary), WebScreenOrientationPortraitPrimar y_Is_Wrong_Should_Be_OrientationPortraitPrimary);

	14 COMPILE_ASSERT(WebScreenOrientationLandscapePrimary == static_cast<WebScreenOrie ntation>(WebCore::OrientationLandscapePrimary), WebScreenOrientationLandscapePri mary_Is_Wrong_Should_Be_OrientationLandscapePrimary);

	15 COMPILE_ASSERT(WebScreenOrientationPortraitSecondary == static_cast<WebScreenOri entation>(WebCore::OrientationPortraitSecondary), WebScreenOrientationPortraitSe condary_Is_Wrong_Should_Be_OrientationPortraitSecondary);

	16 COMPILE_ASSERT(WebScreenOrientationLandscapeSecondary == static_cast<WebScreenOr ientation>(WebCore::OrientationLandscapeSecondary), WebScreenOrientationLandscap eSecondary_Is_Wrong_Should_Be_OrientationLandscapeSecondary);
	Peter Beverloo 2014/02/13 16:33:42 This is more verbose than I hoped it'd be.. I reca This is more verbose than I hoped it'd be.. I recall a thread where someone argued in favor of having a conversion function (toScreenOrientationValue(WebScreenOrientation value) with a switch), but I can't find it. Perhaps a more experienced reviewer can comment on this. Inactive 2014/02/13 17:03:24 This is the pattern I found in other files in Blin Show quoted text On 2014/02/13 16:33:42, Peter Beverloo wrote: > This is more verbose than I hoped it'd be.. I recall a thread where someone > argued in favor of having a conversion function > (toScreenOrientationValue(WebScreenOrientation value) with a switch), but I > can't find it. Perhaps a more experienced reviewer can comment on this. This is the pattern I found in other files in Blink so at least it is not new. I remember someone advising against this though on WebKit side, I am not aware of any similar "rule" in Blink. That said, either way is fine with me. Inactive 2014/02/13 17:06:38 Oh, I have just found: Source/web/AssertMatchingEn Show quoted text On 2014/02/13 17:03:24, Chris Dumez wrote: > On 2014/02/13 16:33:42, Peter Beverloo wrote: > > This is more verbose than I hoped it'd be.. I recall a thread where someone > > argued in favor of having a conversion function > > (toScreenOrientationValue(WebScreenOrientation value) with a switch), but I > > can't find it. Perhaps a more experienced reviewer can comment on this. > > This is the pattern I found in other files in Blink so at least it is not new. I > remember someone advising against this though on WebKit side, I am not aware of > any similar "rule" in Blink. That said, either way is fine with me. Oh, I have just found: Source/web/AssertMatchingEnums.cpp:COMPILE_ASSERT_MATCHING_ENUM() Sounds like this is the expected way of doing this. I'll update the CL. Inactive 2014/02/13 17:12:31 Done. Show quoted text On 2014/02/13 17:06:38, Chris Dumez wrote: > On 2014/02/13 17:03:24, Chris Dumez wrote: > > On 2014/02/13 16:33:42, Peter Beverloo wrote: > > > This is more verbose than I hoped it'd be.. I recall a thread where someone > > > argued in favor of having a conversion function > > > (toScreenOrientationValue(WebScreenOrientation value) with a switch), but I > > > can't find it. Perhaps a more experienced reviewer can comment on this. > > > > This is the pattern I found in other files in Blink so at least it is not new. > I > > remember someone advising against this though on WebKit side, I am not aware > of > > any similar "rule" in Blink. That said, either way is fine with me. > > Oh, I have just found: > Source/web/AssertMatchingEnums.cpp:COMPILE_ASSERT_MATCHING_ENUM() > > Sounds like this is the expected way of doing this. I'll update the CL. Done.
	17

	18 void WebScreenOrientationController::orientationChanged(WebScreenOrientation ori entation)

	19 {

	20 m_private->orientationChanged(static_cast<WebCore::ScreenOrientationValue>(o rientation));

	21 }

	22

	23 } // namespace blink

OLD	NEW