Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 132113004: Fix compiler error on MacOS, remove unused ParameterCount member in CallInterceptorCompiler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 optimization, 464 optimization,
465 argc, 465 argc,
466 receiver, 466 receiver,
467 true); 467 true);
468 } 468 }
469 469
470 470
471 class CallInterceptorCompiler BASE_EMBEDDED { 471 class CallInterceptorCompiler BASE_EMBEDDED {
472 public: 472 public:
473 CallInterceptorCompiler(CallStubCompiler* stub_compiler, 473 CallInterceptorCompiler(CallStubCompiler* stub_compiler,
474 const ParameterCount& arguments,
475 Register name) 474 Register name)
476 : stub_compiler_(stub_compiler), 475 : stub_compiler_(stub_compiler),
477 arguments_(arguments),
478 name_(name) {} 476 name_(name) {}
479 477
480 void Compile(MacroAssembler* masm, 478 void Compile(MacroAssembler* masm,
481 Handle<JSObject> object, 479 Handle<JSObject> object,
482 Handle<JSObject> holder, 480 Handle<JSObject> holder,
483 Handle<Name> name, 481 Handle<Name> name,
484 LookupResult* lookup, 482 LookupResult* lookup,
485 Register receiver, 483 Register receiver,
486 Register scratch1, 484 Register scratch1,
487 Register scratch2, 485 Register scratch2,
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 __ pop(holder); 600 __ pop(holder);
603 __ pop(receiver); 601 __ pop(receiver);
604 // Leave the internal frame. 602 // Leave the internal frame.
605 } 603 }
606 604
607 __ CompareRoot(rax, Heap::kNoInterceptorResultSentinelRootIndex); 605 __ CompareRoot(rax, Heap::kNoInterceptorResultSentinelRootIndex);
608 __ j(not_equal, interceptor_succeeded); 606 __ j(not_equal, interceptor_succeeded);
609 } 607 }
610 608
611 CallStubCompiler* stub_compiler_; 609 CallStubCompiler* stub_compiler_;
612 const ParameterCount& arguments_;
613 Register name_; 610 Register name_;
614 }; 611 };
615 612
616 613
617 void StoreStubCompiler::GenerateRestoreName(MacroAssembler* masm, 614 void StoreStubCompiler::GenerateRestoreName(MacroAssembler* masm,
618 Label* label, 615 Label* label,
619 Handle<Name> name) { 616 Handle<Name> name) {
620 if (!label->is_unused()) { 617 if (!label->is_unused()) {
621 __ bind(label); 618 __ bind(label);
622 __ Move(this->name(), name); 619 __ Move(this->name(), name);
(...skipping 835 matching lines...) Expand 10 before | Expand all | Expand 10 after
1458 Label miss; 1455 Label miss;
1459 GenerateNameCheck(name, &miss); 1456 GenerateNameCheck(name, &miss);
1460 1457
1461 LookupResult lookup(isolate()); 1458 LookupResult lookup(isolate());
1462 LookupPostInterceptor(holder, name, &lookup); 1459 LookupPostInterceptor(holder, name, &lookup);
1463 1460
1464 // Get the receiver from the stack. 1461 // Get the receiver from the stack.
1465 StackArgumentsAccessor args(rsp, arguments()); 1462 StackArgumentsAccessor args(rsp, arguments());
1466 __ movp(rdx, args.GetReceiverOperand()); 1463 __ movp(rdx, args.GetReceiverOperand());
1467 1464
1468 CallInterceptorCompiler compiler(this, arguments(), rcx); 1465 CallInterceptorCompiler compiler(this, rcx);
1469 compiler.Compile(masm(), object, holder, name, &lookup, rdx, rbx, rdi, rax, 1466 compiler.Compile(masm(), object, holder, name, &lookup, rdx, rbx, rdi, rax,
1470 &miss); 1467 &miss);
1471 1468
1472 // Restore receiver. 1469 // Restore receiver.
1473 __ movp(rdx, args.GetReceiverOperand()); 1470 __ movp(rdx, args.GetReceiverOperand());
1474 1471
1475 GenerateJumpFunction(object, rax, &miss); 1472 GenerateJumpFunction(object, rax, &miss);
1476 1473
1477 HandlerFrontendFooter(&miss); 1474 HandlerFrontendFooter(&miss);
1478 1475
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
1858 // ----------------------------------- 1855 // -----------------------------------
1859 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1856 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1860 } 1857 }
1861 1858
1862 1859
1863 #undef __ 1860 #undef __
1864 1861
1865 } } // namespace v8::internal 1862 } } // namespace v8::internal
1866 1863
1867 #endif // V8_TARGET_ARCH_X64 1864 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698