makes tests faster, see #304

lib/src/report.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Summarizes the information produced by the checker.
 library dev_compiler.src.report;
 
 import 'dart:math' show max;
 
 import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
@@ skipping 16 matching lines @@
 
   /// Flushes errors to the log. Until this is called, errors are buffered.
   void flush() {
     // TODO(jmesserly): this code was taken from analyzer_cli.
     // sort errors
     _errors.sort((AnalysisError error1, AnalysisError error2) {
       // severity
       var severity1 = _strongModeErrorSeverity(error1);
       var severity2 = _strongModeErrorSeverity(error2);
       int compare = severity2.compareTo(severity1);
-      if (compare != 0) {
-        return compare;
-      }
+      if (compare != 0) return compare;
+
       // path
       compare = Comparable.compare(error1.source.fullName.toLowerCase(),
           error2.source.fullName.toLowerCase());
-      if (compare != 0) {
-        return compare;
-      }
+      if (compare != 0) return compare;
+
       // offset
-      return error1.offset - error2.offset;
+      compare = error1.offset - error2.offset;
+      if (compare != 0) return compare;
+
+      // compare message, in worst case.
+      return error1.message.compareTo(error2.message);

[vsm, 2015/08/28 17:12:31]

nice :-)

     });
 
     _errors.forEach(listener.onError);
     _errors.clear();
   }
 
   void onError(AnalysisError error) {
     _errors.add(error);
   }
 }
@@ skipping 293 matching lines @@
 
   visitMessage(MessageSummary message) {
     var kind = message.kind;
     errorCount.putIfAbsent(currentPackage, () => <String, int>{});
     errorCount[currentPackage].putIfAbsent(kind, () => 0);
     errorCount[currentPackage][kind]++;
     totals.putIfAbsent(kind, () => 0);
     totals[kind]++;
   }
 }