Issue 1321103002: makes tests faster, see #304

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1321103002: makes tests faster, see #304 (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly

Modified:
5 years, 3 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

makes tests faster, see #304 this doesn't completely address the issue, but it knocks off some of the time. also attempt to stabilize error message order. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/637eeefc664be340e5636edace0dc0aa6e1ba900

Patch Set 3 : stabalize messages #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -75 lines)			Patch
M	lib/src/compiler.dart	View		3 chunks	+12 lines, -4 lines	0 comments	Download
M	lib/src/report.dart	View	1 2	1 chunk	+9 lines, -7 lines	1 comment	Download
M	test/codegen/expect/js_test.txt	View	1 2	4 chunks	+9 lines, -9 lines	0 comments	Download
M	test/codegen/expect/opassign.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/codegen/expect/unittest.txt	View	1 2	5 chunks	+37 lines, -37 lines	0 comments	Download
M	test/codegen_test.dart	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	tool/sdk_expected_errors.txt	View	1 2	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

lgtm https://codereview.chromium.org/1321103002/diff/40001/lib/src/report.dart File lib/src/report.dart (right): https://codereview.chromium.org/1321103002/diff/40001/lib/src/report.dart#newcode49 lib/src/report.dart:49: return error1.message.compareTo(error2.message); nice :-)

5 years, 3 months ago (2015-08-28 17:12:32 UTC) #3

Jennifer Messerly

5 years, 3 months ago (2015-08-28 17:14:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
637eeefc664be340e5636edace0dc0aa6e1ba900 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1321103002: makes tests faster, see #304 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : stabalize messages #

Messages