Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1321033004: [MD settings] currentRoute to Object (Closed)

Created:
5 years, 3 months ago by dschuyler
Modified:
5 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] changing currentRoute property to Object This CL changes the currentRoute property from an Array (which is incorrect, per Tommy) to an Object. BUG=425627 Committed: https://crrev.com/df38e93145eed696c3c6efea3c24d22776366b86 Cr-Commit-Position: refs/heads/master@{#347949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/search_page/search_page.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dschuyler
5 years, 3 months ago (2015-09-09 01:13:39 UTC) #2
Dan Beam
lgtm
5 years, 3 months ago (2015-09-09 01:45:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321033004/1
5 years, 3 months ago (2015-09-09 16:46:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 16:54:38 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df38e93145eed696c3c6efea3c24d22776366b86 Cr-Commit-Position: refs/heads/master@{#347949}
5 years, 3 months ago (2015-09-09 16:55:13 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:00:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df38e93145eed696c3c6efea3c24d22776366b86
Cr-Commit-Position: refs/heads/master@{#347949}

Powered by Google App Engine
This is Rietveld 408576698