Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1321033003: Fix formAction return value for empty formaction content attribute. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, vivekg, dglazkov+blink, blink-reviews-html_chromium.org, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix formAction return value for empty formaction content attribute. According to the standard and web-platform-tests, empty attribute value should return the document URL. https://html.spec.whatwg.org/multipage/forms.html#dom-fs-formaction > The formAction IDL attribute must reflect the formaction content attribute, > except that on getting, when the content attribute is missing or its value is > the empty string, the document's address must be returned instead. This CL removes empty formaction tests in submit-form-attributes.html. html/semantics/forms/attributes-common-to-form-controls/formaction*.html cover them. BUG=520835 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/submit-form-attributes.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/submit-form-attributes-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLButtonElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, would you review this please?
5 years, 3 months ago (2015-09-02 05:21:39 UTC) #2
keishi
lgtm
5 years, 3 months ago (2015-09-02 05:34:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321033003/1
5 years, 3 months ago (2015-09-02 05:35:19 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:30:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201617

Powered by Google App Engine
This is Rietveld 408576698