Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132103002: Update HTML forms classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update HTML forms classes to use OVERRIDE / FINAL when needed Update HTML forms classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M Source/core/html/forms/BaseCheckableInputType.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/html/forms/BaseTextInputType.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/ButtonInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/CheckboxInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/DateInputType.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/EmailInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/HiddenInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ImageInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/MonthInputType.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/NumberInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RadioInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RangeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ResetInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/SearchInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/SubmitInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TelephoneInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/forms/TextInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TimeInputType.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/URLInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/WeekInputType.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-09 17:34:44 UTC) #1
esprehn
rslgtm
6 years, 11 months ago (2014-01-09 18:44:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/132103002/1
6 years, 11 months ago (2014-01-09 20:06:08 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 21:09:41 UTC) #4
Message was sent while issue was closed. 
Change committed as 164803

Powered by Google App Engine
This is Rietveld 408576698