Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1321023006:
J420ToABGR for 1 step Android J420 conversion (Closed)
|
Created:
5 years, 3 months ago by fbarchard1 Modified:
5 years, 3 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionroll libyuv from r1475 to r1478 for new J420 function.
J420ToABGR is impliemented using I420ToABGR with a jpeg color matrix parameter.
BUG=libyuv:470
Committed: https://crrev.com/3e2b051608a8061cc8e97cab402c40c3767416d6
Cr-Commit-Position: refs/heads/master@{#347846}
Patch Set 1 #Patch Set 2 : Direct J420ToABGR for android #
Total comments: 1
Patch Set 3 : deps roll pushed. this cl is just the skcanvas call for j420 now #Messages
Total messages: 21 (10 generated)
fbarchard@chromium.org changed reviewers: + dalecurtis@chromium.org
fbarchard@chromium.org changed reviewers: + fbarchard@chromium.org
try bots are passing. https://codereview.chromium.org/1321023006/diff/20001/media/blink/skcanvas_vi... File media/blink/skcanvas_video_renderer.cc (right): https://codereview.chromium.org/1321023006/diff/20001/media/blink/skcanvas_vi... media/blink/skcanvas_video_renderer.cc:460: LIBYUV_I422_TO_ARGB( Note J422ToARGB and J422ToABGR are also available in libyuv, if we want to check if (CheckColorSpace(video_frame, COLOR_SPACE_JPEG)) { and support that. For actual jpeg images, 422 was historically more common than 420. With photoshop, depending on quality setting, you can get 420, 422 or 444.
lgtm
The CQ bit was checked by fbarchard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321023006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321023006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fbarchard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321023006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321023006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fbarchard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321023006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321023006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fbarchard@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org Link to the patchset: https://codereview.chromium.org/1321023006/#ps40001 (title: "deps roll pushed. this cl is just the skcanvas call for j420 now")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321023006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321023006/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/3e2b051608a8061cc8e97cab402c40c3767416d6 Cr-Commit-Position: refs/heads/master@{#347846} |
