Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1321013005: Stage sloppy let (Closed)

Created:
5 years, 3 months ago by Dan Ehrenberg
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage sloppy let Move the --harmony-sloppy-let flag to staging for further testing, and update test262 for the new passing tests. Also increase the strictness of the parser, even in sloppy mode, to disallow "new legacy compat" for for (let x = 5 in {}) {} which is now a SyntaxError. BUG=v8:3305 LOG=Y R=adamk Committed: https://crrev.com/a2841eb0dc1f9823faac46320ecae60aa5be0fe0 Cr-Commit-Position: refs/heads/master@{#30525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -67 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/test262-es6/test262-es6.status View 2 chunks +15 lines, -64 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Ehrenberg
5 years, 3 months ago (2015-09-01 19:05:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321013005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321013005/1
5 years, 3 months ago (2015-09-01 19:06:03 UTC) #3
adamk
lgtm
5 years, 3 months ago (2015-09-01 19:13:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 19:31:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321013005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321013005/1
5 years, 3 months ago (2015-09-01 20:01:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 20:03:20 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 20:03:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2841eb0dc1f9823faac46320ecae60aa5be0fe0
Cr-Commit-Position: refs/heads/master@{#30525}

Powered by Google App Engine
This is Rietveld 408576698