Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1321003002: Reduce (or remove?) blinding white flash on chrome://apps (Closed)

Created:
5 years, 3 months ago by Dan Beam
Modified:
5 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce (or remove?) blinding white flash on chrome://apps R=estade@chromium.org BUG=126341 Committed: https://crrev.com/7d89c927fb0f77fc4d9a8bc8cd93e6807722d39c Cr-Commit-Position: refs/heads/master@{#346157}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 11 (3 generated)
Dan Beam
5 years, 3 months ago (2015-08-28 03:03:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321003002/1
5 years, 3 months ago (2015-08-28 03:39:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 04:49:13 UTC) #5
Evan Stade
lgtm i guess but satisfy my curiosity https://codereview.chromium.org/1321003002/diff/1/chrome/browser/resources/ntp4/new_tab.html File chrome/browser/resources/ntp4/new_tab.html (left): https://codereview.chromium.org/1321003002/diff/1/chrome/browser/resources/ntp4/new_tab.html#oldcode33 chrome/browser/resources/ntp4/new_tab.html:33: <link id="themecss" ...
5 years, 3 months ago (2015-08-28 14:48:28 UTC) #6
Dan Beam
https://codereview.chromium.org/1321003002/diff/1/chrome/browser/resources/ntp4/new_tab.html File chrome/browser/resources/ntp4/new_tab.html (left): https://codereview.chromium.org/1321003002/diff/1/chrome/browser/resources/ntp4/new_tab.html#oldcode33 chrome/browser/resources/ntp4/new_tab.html:33: <link id="themecss" rel="stylesheet"> On 2015/08/28 14:48:28, Evan Stade wrote: ...
5 years, 3 months ago (2015-08-28 15:51:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321003002/1
5 years, 3 months ago (2015-08-28 15:51:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 15:56:41 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 15:57:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d89c927fb0f77fc4d9a8bc8cd93e6807722d39c
Cr-Commit-Position: refs/heads/master@{#346157}

Powered by Google App Engine
This is Rietveld 408576698