Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 1320933002: Revert of Make separate net and url GN targets with and without ICU (Closed)

Created:
5 years, 3 months ago by dewittj
Modified:
5 years, 3 months ago
Reviewers:
brettw, mmenke, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make separate net and url GN targets with and without ICU (patchset #8 id:300001 of https://codereview.chromium.org/1287893005/ ) Reason for revert: http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/29757/steps/gn_check/logs/stdio Likely broke build GN check Original issue's description: > Make separate net and url GN targets with and without ICU > > The net and url GYP files were modified in crrev.com/933293003 > so Cronet could be built side-by-side with Chrome. However GN > files are not modified. This CL keeps the GN files in sync > with the GYP files. > > BUG=522096 > > Committed: https://crrev.com/4c8c6921ca6739d16f6551635328faf164848f9d > Cr-Commit-Position: refs/heads/master@{#345891} TBR=mmenke@chromium.org,brettw@chromium.org,xunjieli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+620 lines, -557 lines) Patch
M net/BUILD.gn View 12 chunks +440 lines, -389 lines 0 comments Download
M net/net.gypi View 6 chunks +82 lines, -88 lines 0 comments Download
M net/net_common.gypi View 2 chunks +26 lines, -7 lines 0 comments Download
M url/BUILD.gn View 3 chunks +64 lines, -73 lines 0 comments Download
A url/config.gni View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dewittj
Created Revert of Make separate net and url GN targets with and without ICU
5 years, 3 months ago (2015-08-27 17:13:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320933002/1
5 years, 3 months ago (2015-08-27 17:13:50 UTC) #2
xunjieli
On 2015/08/27 17:13:50, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-08-27 17:14:22 UTC) #4
dewittj
Thanks. What's the review url or commit hash?
5 years, 3 months ago (2015-08-27 17:15:12 UTC) #6
dewittj
5 years, 3 months ago (2015-08-27 17:15:58 UTC) #7
nm, found it.

Powered by Google App Engine
This is Rietveld 408576698