Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 132093003: Revert of Fix Mac fontconfig build (Closed)

Created:
6 years, 11 months ago by vandebo (ex-Chrome)
Modified:
6 years, 11 months ago
Reviewers:
bungeman-skia, epoger
CC:
skia-review_googlegroups.com, Lei Zhang
Base URL:
https://skia.googlesource.com/skia.git@noembed
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/113203003/ Reason for revert: Broken under XCode. TBR=bungeman@google.com,epoger@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=12997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -531 lines) Patch
M gyp/common_variables.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M gyp/fontconfig.gyp View 3 chunks +4 lines, -103 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/fontconfig/README.chromium View 1 chunk +3 lines, -8 lines 0 comments Download
A third_party/fontconfig/config/mac/config.h View 1 chunk +358 lines, -0 lines 0 comments Download
D third_party/fontconfig/config/mac/config.h.template View 1 chunk +0 lines, -362 lines 0 comments Download
D third_party/fontconfig/process-template.py View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vandebo (ex-Chrome)
Created Revert of Fix Mac fontconfig build
6 years, 11 months ago (2014-01-09 17:52:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/132093003/1
6 years, 11 months ago (2014-01-09 17:52:47 UTC) #2
commit-bot: I haz the power
Change committed as 12997
6 years, 11 months ago (2014-01-09 17:53:00 UTC) #3
vandebo (ex-Chrome)
On 2014/01/09 17:52:44, vandebo wrote: > Created Revert of Fix Mac fontconfig build Actually, the ...
6 years, 11 months ago (2014-01-09 17:59:40 UTC) #4
epoger
On 2014/01/09 17:59:40, vandebo wrote: > On 2014/01/09 17:52:44, vandebo wrote: > > Created Revert ...
6 years, 11 months ago (2014-01-09 18:13:26 UTC) #5
vandebo (ex-Chrome)
6 years, 11 months ago (2014-01-09 18:16:10 UTC) #6
Message was sent while issue was closed.
On 2014/01/09 18:13:26, epoger wrote:
> On 2014/01/09 17:59:40, vandebo wrote:
> > On 2014/01/09 17:52:44, vandebo wrote:
> > > Created Revert of Fix Mac fontconfig build
> > 
> > Actually, the problem seems to be that argparse isn't available on Mac 10.6,
> > which has python 2.6
> 
> Oh, that frustrating problem again.
> 
> Maybe change to use optparse.  "deprecated" as of Python 2.7, but available in
> both 2.6 and 2.7.

Yea, it looks everything I used from argparse is available in optparse.

Powered by Google App Engine
This is Rietveld 408576698