Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320923005: Fill in mic_positions property. (Closed)

Created:
5 years, 3 months ago by hychao
Modified:
5 years, 3 months ago
Reviewers:
ajm, jennyz
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fill in mic_positions property. BUG=451188 Committed: https://crrev.com/19893ba50f655dcf5e45ce4a3cb12640d5ae7ced Cr-Commit-Position: refs/heads/master@{#348097}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chromeos/audio/audio_device.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/audio/audio_device.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/dbus/audio_node.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/dbus/audio_node.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/cras_audio_client.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
ajm
Not sure you were ready for review, but lgtm.
5 years, 3 months ago (2015-08-29 01:46:08 UTC) #2
hychao
I've uprev'ed cros_system_api to update CRAS dbus property. It's good for review now, thanks!
5 years, 3 months ago (2015-09-04 07:46:29 UTC) #4
ajm
Still lgtm.
5 years, 3 months ago (2015-09-04 22:04:20 UTC) #5
jennyz
lgtm
5 years, 3 months ago (2015-09-09 16:17:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320923005/20001
5 years, 3 months ago (2015-09-09 16:32:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/60682)
5 years, 3 months ago (2015-09-09 16:59:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320923005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320923005/40001
5 years, 3 months ago (2015-09-10 04:32:14 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-10 05:05:29 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/19893ba50f655dcf5e45ce4a3cb12640d5ae7ced Cr-Commit-Position: refs/heads/master@{#348097}
5 years, 3 months ago (2015-09-10 05:06:13 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:07:36 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/19893ba50f655dcf5e45ce4a3cb12640d5ae7ced
Cr-Commit-Position: refs/heads/master@{#348097}

Powered by Google App Engine
This is Rietveld 408576698