Add a flag to override unlimitedStorage quota for any origins.

Add a flag to override unlimitedStorage quota for any origins.

This CL adds "--unlimited-storage" command line flag, that override unlimitedStorage quota for all origins.

BUG=224381
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191538

[tzik, 2013-03-28 23:49:54]

Hi.

I'd like to add --unlimited-storage for debugging plugin that uses FileSystem.
Could you take a look?

[kinuko, 2013-03-29 00:10:09]

(-aaron, +michaeln)

https://codereview.chromium.org/13209004/diff/1/content/public/common/content...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/13209004/diff/1/content/public/common/content...
content/public/common/content_switches.cc:774: // Allocates unlimited quota for
all origins.
'Allocates' sounds wrong to me.  Also I think we should make it clear that it's
intended to be used only for developers.  Maybe something like:

"This overrides per-origin quota settings to always return unlimited storage for
any apps/origins.  This should be used only for testing purpose."

[tzik, 2013-03-29 19:52:00]

Updated!

Also, updated issue title and description.

https://codereview.chromium.org/13209004/diff/1/content/public/common/content...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/13209004/diff/1/content/public/common/content...
content/public/common/content_switches.cc:774: // Allocates unlimited quota for
all origins.
On 2013/03/29 00:10:09, kinuko wrote:
> 'Allocates' sounds wrong to me.  Also I think we should make it clear that
it's
> intended to be used only for developers.  Maybe something like:
> 
> "This overrides per-origin quota settings to always return unlimited storage
for
> any apps/origins.  This should be used only for testing purpose."

Done.

[kinuko, 2013-03-29 20:04:03]

lgtm (if owners are ok)

[tzik, 2013-03-29 20:49:10]

[-Jói, +Avi] since he is absent.

Avi, could you take a look? Can I add this switch?

[Avi (use Gerrit), 2013-03-29 21:17:48]

Why are you adding a flag in content but only using it in chrome? That's a sign
of bad layering.

Why can't you add the flag to chrome/common/chrome_switches.h?

[tzik, 2013-03-29 22:46:35]

On 2013/03/29 21:17:48, Avi wrote:
> Why are you adding a flag in content but only using it in chrome? That's a
sign
> of bad layering.
> 
> Why can't you add the flag to chrome/common/chrome_switches.h?

Ah sorry, I didn't aware that. I moved them to chrome_switches.

[Avi (use Gerrit), 2013-03-29 22:47:59]

Then kinuko's ok is enough :)

[tzik, 2013-03-29 22:59:11]

On 2013/03/29 22:47:59, Avi wrote:
> Then kinuko's ok is enough :)

Yes for chrome_switches. Thanks!

[tzik, 2013-03-29 23:02:44]

[+benwells]

Ben: Could you take a look as a chrome/browser/extensions OWNERS?

[michaeln, 2013-03-29 23:38:38]

lgtm2

[benwells, 2013-03-30 02:06:03]

lgtm

[tzik, 2013-03-30 02:14:56]

Thanks!

[commit-bot: I haz the power, 2013-03-30 02:15:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/13209004/11001

[commit-bot: I haz the power, 2013-03-30 17:03:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/13209004/11001

[commit-bot: I haz the power, 2013-03-30 18:59:02]

Change committed as 191538