Create the UserManager's Dialog Manager during init.

chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/profiles/user_manager_mac.h"
 
 #include "base/mac/foundation_util.h"
 #include "chrome/app/chrome_command_ids.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 214 matching lines @@
 }
 
 - (void)closeButtonClicked:(NSButton*)button {
   [self close];
 }
 
 - (void)close {
   constrained_window_->CloseWebContentsModalDialog();
 }
 
+- (void)dealloc {
+  //auto closeButton = [[self window] standardWindowButton:NSWindowCloseButton];
+  //[closeButton setTarget:nil];

[groby-ooo-7-16, 2015/09/12 00:42:16]

Remove commented out code

[anthonyvd, 2015/09/14 23:59:18]

oops, missed this. Thanks!

+  constrained_window_->CloseWebContentsModalDialog();
+
+  [super dealloc];
+}
+
 @end
 
 // Window controller for the User Manager view.
 @interface UserManagerWindowController : NSWindowController <NSWindowDelegate> {
  @private
   scoped_ptr<content::WebContents> webContents_;
   scoped_ptr<UserManagerWebContentsDelegate> webContentsDelegate_;
   UserManagerMac* userManagerObserver_;  // Weak.
   scoped_ptr<UserManagerModalManagerDelegate> modal_manager_delegate_;
   base::scoped_nsobject<ReauthDialogWindowController> reauth_window_controller_;
@@ skipping 38 matching lines @@
   if ((self = [super initWithWindow:window])) {
     userManagerObserver_ = userManagerObserver;
 
     // Initialize the web view.
     webContents_.reset(content::WebContents::Create(
         content::WebContents::CreateParams(profile)));
     window.contentView = webContents_->GetNativeView();
     webContentsDelegate_.reset(new UserManagerWebContentsDelegate());
     webContents_->SetDelegate(webContentsDelegate_.get());
 
+    web_modal::WebContentsModalDialogManager::CreateForWebContents(
+        webContents_.get());
+    modal_manager_delegate_.reset(
+        new UserManagerModalManagerDelegate([[self window] contentView]));
+    web_modal::WebContentsModalDialogManager::FromWebContents(
+        webContents_.get())->SetDelegate(modal_manager_delegate_.get());
+
     [[NSNotificationCenter defaultCenter]
         addObserver:self
            selector:@selector(windowWillClose:)
                name:NSWindowWillCloseNotification
              object:self.window];
   }
   return self;
 }
 
 - (void)dealloc {
@@ skipping 41 matching lines @@
   return [[self window] isVisible];
 }
 
 - (void)windowWillClose:(NSNotification*)notification {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   DCHECK(userManagerObserver_);
   userManagerObserver_->WindowWasClosed();
 }
 
 - (void)showReauthDialogWithProfile:(Profile*)profile email:(std::string)email {
-  // Make sure there's a WebContentsModalDialogManager for this UserManager's
-  // web contents.
-  web_modal::WebContentsModalDialogManager::CreateForWebContents(
-      webContents_.get());
-  modal_manager_delegate_.reset(
-      new UserManagerModalManagerDelegate([[self window] contentView]));
-  web_modal::WebContentsModalDialogManager::FromWebContents(
-      webContents_.get())->SetDelegate(modal_manager_delegate_.get());
   reauth_window_controller_.reset(
       [[ReauthDialogWindowController alloc]
           initWithProfile:profile
                     email:email
               webContents:webContents_.get()]);
 }
 
 - (void)closeReauthDialog {
   [reauth_window_controller_ close];
 }
@@ skipping 94 matching lines @@
   ProfileMetrics::LogTimeToOpenUserManager(
       base::Time::Now() - user_manager_started_showing_);
   user_manager_started_showing_ = base::Time();
 }
 
 void UserManagerMac::WindowWasClosed() {
   CloseReauthDialog();
   instance_ = NULL;
   delete this;
 }