Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Side by Side Diff: Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1320843005: Update outer flow thread membership before changing multicolness. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 void createAndInsertMultiColumnSet(LayoutBox* insertBefore = nullptr); 211 void createAndInsertMultiColumnSet(LayoutBox* insertBefore = nullptr);
212 void createAndInsertSpannerPlaceholder(LayoutBox* spannerObjectInFlowThread, LayoutObject* insertedBeforeInFlowThread); 212 void createAndInsertSpannerPlaceholder(LayoutBox* spannerObjectInFlowThread, LayoutObject* insertedBeforeInFlowThread);
213 void destroySpannerPlaceholder(LayoutMultiColumnSpannerPlaceholder*); 213 void destroySpannerPlaceholder(LayoutMultiColumnSpannerPlaceholder*);
214 virtual bool descendantIsValidColumnSpanner(LayoutObject* descendant) const; 214 virtual bool descendantIsValidColumnSpanner(LayoutObject* descendant) const;
215 215
216 void addColumnSetToThread(LayoutMultiColumnSet*) override; 216 void addColumnSetToThread(LayoutMultiColumnSet*) override;
217 void willBeRemovedFromTree() override; 217 void willBeRemovedFromTree() override;
218 void skipColumnSpanner(LayoutBox*, LayoutUnit logicalTopInFlowThread) overri de; 218 void skipColumnSpanner(LayoutBox*, LayoutUnit logicalTopInFlowThread) overri de;
219 void flowThreadDescendantWasInserted(LayoutObject*) final; 219 void flowThreadDescendantWasInserted(LayoutObject*) final;
220 void flowThreadDescendantWillBeRemoved(LayoutObject*) final; 220 void flowThreadDescendantWillBeRemoved(LayoutObject*) final;
221 void flowThreadDescendantStyleWillChange(LayoutObject*, StyleDifference, con st ComputedStyle& newStyle) override; 221 void flowThreadDescendantStyleWillChange(LayoutBox*, StyleDifference, const ComputedStyle& newStyle) override;
222 void flowThreadDescendantStyleDidChange(LayoutObject*, StyleDifference, cons t ComputedStyle& oldStyle) override; 222 void flowThreadDescendantStyleDidChange(LayoutBox*, StyleDifference, const C omputedStyle& oldStyle) override;
223 void computePreferredLogicalWidths() override; 223 void computePreferredLogicalWidths() override;
224 void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, L ogicalExtentComputedValues&) const override; 224 void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, L ogicalExtentComputedValues&) const override;
225 void updateLogicalWidth() override; 225 void updateLogicalWidth() override;
226 void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage) override; 226 void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage) override;
227 void updateMinimumPageHeight(LayoutUnit offset, LayoutUnit minHeight) overri de; 227 void updateMinimumPageHeight(LayoutUnit offset, LayoutUnit minHeight) overri de;
228 bool addForcedColumnBreak(LayoutUnit, LayoutObject* breakChild, bool isBefor e, LayoutUnit* offsetBreakAdjustment = nullptr) override; 228 bool addForcedColumnBreak(LayoutUnit, LayoutObject* breakChild, bool isBefor e, LayoutUnit* offsetBreakAdjustment = nullptr) override;
229 229
230 // The last set we worked on. It's not to be used as the "current set". The concept of a 230 // The last set we worked on. It's not to be used as the "current set". The concept of a
231 // "current set" is difficult, since layout may jump back and forth in the t ree, due to wrong 231 // "current set" is difficult, since layout may jump back and forth in the t ree, due to wrong
232 // top location estimates (due to e.g. margin collapsing), and possibly for other reasons. 232 // top location estimates (due to e.g. margin collapsing), and possibly for other reasons.
(...skipping 12 matching lines...) Expand all
245 bool m_isBeingEvacuated; 245 bool m_isBeingEvacuated;
246 }; 246 };
247 247
248 // Cannot use DEFINE_LAYOUT_OBJECT_TYPE_CASTS here, because isMultiColumnFlowThr ead() is defined in 248 // Cannot use DEFINE_LAYOUT_OBJECT_TYPE_CASTS here, because isMultiColumnFlowThr ead() is defined in
249 // LayoutFlowThread, not in LayoutObject. 249 // LayoutFlowThread, not in LayoutObject.
250 DEFINE_TYPE_CASTS(LayoutMultiColumnFlowThread, LayoutFlowThread, object, object- >isLayoutMultiColumnFlowThread(), object.isLayoutMultiColumnFlowThread()); 250 DEFINE_TYPE_CASTS(LayoutMultiColumnFlowThread, LayoutFlowThread, object, object- >isLayoutMultiColumnFlowThread(), object.isLayoutMultiColumnFlowThread());
251 251
252 } // namespace blink 252 } // namespace blink
253 253
254 #endif // LayoutMultiColumnFlowThread_h 254 #endif // LayoutMultiColumnFlowThread_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutFlowThread.h ('k') | Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698