[heap] Limit friendship of the Heap class to essentials.

src/heap/heap.h

Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 254b19f83cb54714fd80a897f14242331ff0fb59..b5ede40572226ecc498de4ccb01fa86df126d3ef 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1224,14 +1224,26 @@ class Heap {
     roots_[kNonMonomorphicCacheRootIndex] = value;
   }
 
-  void public_set_empty_script(Script* script) {
-    roots_[kEmptyScriptRootIndex] = script;
-  }
-
   void public_set_materialized_objects(FixedArray* objects) {
     roots_[kMaterializedObjectsRootIndex] = objects;
   }
 
+  void public_set_code_stub_context(Object* value) {

[Hannes Payer (out of office), 2015/08/27 09:25:02]

These are not "real" setters. Hence, they should not use the setter syntax. Why
public_*? Is this the right terminology? I think they are public because they
are part of the public section in heap.

[Michael Starzinger, 2015/08/27 09:27:48]

The "public" prefix is to not clash with the private versions of these setters.
There are private setters for the entire root set on the heap further down
below. As for the naming, I don't have a strong opinion, choose whatever name
you like and I'll rename it. But just FYI, this is not new, this has been here
for ages, I am just unifying it.

[Hannes Payer (out of office), 2015/08/27 10:11:00]

I would prefer SetRoot* 

[Michael Starzinger, 2015/08/27 11:09:13]

Done. Your slight preference is my command.

+    roots_[kCodeStubContextRootIndex] = value;
+  }
+
+  void public_set_code_stub_exports_object(JSObject* value) {
+    roots_[kCodeStubExportsObjectRootIndex] = value;
+  }
+
+  void public_set_script_list(Object* value) {
+    roots_[kScriptListRootIndex] = value;
+  }
+
+  void public_set_string_table(StringTable* value) {
+    roots_[kStringTableRootIndex] = value;
+  }
+
   // Set the stack limit in the roots_ array.  Some architectures generate
   // code that looks here, because it is faster than loading from the static
   // jslimit_/real_jslimit_ variable in the StackGuard.
@@ -2407,21 +2419,23 @@ class Heap {
 
   StrongRootsList* strong_roots_list_;
 
+  // Classes in "heap" can be friends.
   friend class AlwaysAllocateScope;
-  friend class Bootstrapper;
-  friend class Deserializer;
-  friend class Factory;
   friend class GCCallbacksScope;
   friend class GCTracer;
   friend class HeapIterator;
   friend class IncrementalMarking;
-  friend class Isolate;
   friend class MarkCompactCollector;
   friend class MarkCompactMarkingVisitor;
-  friend class MapCompact;
   friend class Page;
   friend class StoreBuffer;
 
+  // The allocator interface.
+  friend class Factory;
+
+  // The Isolate constructs use.
+  friend class Isolate;
+
   // Used in cctest.
   friend class HeapTester;