Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: src/code-stubs.cc

Issue 1320843002: [heap] Limit friendship of the Heap class to essentials. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/cpu-profiler.h" 10 #include "src/cpu-profiler.h"
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 167
168 if (UseSpecialCache()) { 168 if (UseSpecialCache()) {
169 AddToSpecialCache(new_object); 169 AddToSpecialCache(new_object);
170 } else { 170 } else {
171 // Update the dictionary and the root in Heap. 171 // Update the dictionary and the root in Heap.
172 Handle<UnseededNumberDictionary> dict = 172 Handle<UnseededNumberDictionary> dict =
173 UnseededNumberDictionary::AtNumberPut( 173 UnseededNumberDictionary::AtNumberPut(
174 Handle<UnseededNumberDictionary>(heap->code_stubs()), 174 Handle<UnseededNumberDictionary>(heap->code_stubs()),
175 GetKey(), 175 GetKey(),
176 new_object); 176 new_object);
177 heap->public_set_code_stubs(*dict); 177 heap->SetRootCodeStubs(*dict);
178 } 178 }
179 code = *new_object; 179 code = *new_object;
180 } 180 }
181 181
182 Activate(code); 182 Activate(code);
183 DCHECK(!NeedsImmovableCode() || 183 DCHECK(!NeedsImmovableCode() ||
184 heap->lo_space()->Contains(code) || 184 heap->lo_space()->Contains(code) ||
185 heap->code_space()->FirstPage()->Contains(code->address())); 185 heap->code_space()->FirstPage()->Contains(code->address()));
186 return Handle<Code>(code, isolate()); 186 return Handle<Code>(code, isolate());
187 } 187 }
(...skipping 878 matching lines...) Expand 10 before | Expand all | Expand 10 after
1066 1066
1067 if (type->Is(Type::UntaggedPointer())) { 1067 if (type->Is(Type::UntaggedPointer())) {
1068 return Representation::External(); 1068 return Representation::External();
1069 } 1069 }
1070 1070
1071 DCHECK(!type->Is(Type::Untagged())); 1071 DCHECK(!type->Is(Type::Untagged()));
1072 return Representation::Tagged(); 1072 return Representation::Tagged();
1073 } 1073 }
1074 } // namespace internal 1074 } // namespace internal
1075 } // namespace v8 1075 } // namespace v8
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698