Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320833003: Expose SignalSyncPoint through MGL api (Closed)

Created:
5 years, 3 months ago by jamesr
Modified:
5 years, 3 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose SignalSyncPoint through MGL api This is the last bit of functionality missing relative to c/gles2/ R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0cc70ad8a3842cd716ed432efca950a84891ab39

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -13 lines) Patch
M mojo/gles2/control_thunks_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/gles2/control_thunks_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/mgl_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/gpu/mojo_context_support.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/c/gpu/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download
A mojo/public/c/gpu/MGL/mgl_signal_sync_point.h View 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/public/platform/native/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
A mojo/public/platform/native/mgl_signal_sync_point_thunks.h View 1 chunk +50 lines, -0 lines 1 comment Download
A mojo/public/platform/native/mgl_signal_sync_point_thunks.c View 1 chunk +25 lines, -0 lines 0 comments Download
M shell/native_application_support.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Dependent Patchsets:

Issue 1310003004 Patch 1

Messages

Total messages: 3 (0 generated)
jamesr
5 years, 3 months ago (2015-08-28 20:07:27 UTC) #1
viettrungluu
lgtm w/nit https://codereview.chromium.org/1320833003/diff/1/mojo/public/platform/native/mgl_signal_sync_point_thunks.h File mojo/public/platform/native/mgl_signal_sync_point_thunks.h (right): https://codereview.chromium.org/1320833003/diff/1/mojo/public/platform/native/mgl_signal_sync_point_thunks.h#newcode50 mojo/public/platform/native/mgl_signal_sync_point_thunks.h:50: #endif // MOJO_PUBLIC_PLATFORM_NATIVE_MGL_THUNKS_H_ update the comment
5 years, 3 months ago (2015-08-28 20:20:35 UTC) #2
jamesr
5 years, 3 months ago (2015-08-28 20:31:41 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0cc70ad8a3842cd716ed432efca950a84891ab39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698