Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132083002: Move SigninManagerDelegate into the Signin component. (Closed)

Created:
6 years, 11 months ago by blundell
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move SigninManagerDelegate into the Signin component. This interface is intended for embedders to supply to the Signin component. It had been created during an earlier aborted effort to componentize Signin. BUG=332107 TBR=joi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -28 lines) Patch
M chrome/browser/signin/chrome_signin_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/signin/signin_manager_delegate.h View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + components/signin/core/signin_manager_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
blundell
6 years, 11 months ago (2014-01-09 16:37:11 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 11 months ago (2014-01-09 22:09:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/132083002/1
6 years, 11 months ago (2014-01-09 22:34:14 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44195
6 years, 11 months ago (2014-01-09 23:19:22 UTC) #4
blundell
TBR'ing joi for //components/signin.gypi
6 years, 11 months ago (2014-01-10 08:33:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/132083002/1
6 years, 11 months ago (2014-01-10 08:34:18 UTC) #6
commit-bot: I haz the power
Change committed as 244139
6 years, 11 months ago (2014-01-10 11:03:13 UTC) #7
Jói
6 years, 11 months ago (2014-01-10 11:12:16 UTC) #8
Message was sent while issue was closed. 
//components/signin.gypi LGTM

Powered by Google App Engine
This is Rietveld 408576698