Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1320823002: Introduce Position version of enclsoingBlock() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce Position version of enclsoingBlock() This patch introduces |Position| version of |enclosingBlock()| as a preparation of templatzing it. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201289

Patch Set 1 : 2015-08-27T12:35:12 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-27 04:13:07 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-08-27 04:17:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320823002/1
5 years, 3 months ago (2015-08-27 04:31:41 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 05:41:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201289

Powered by Google App Engine
This is Rietveld 408576698