Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 1320813002: SegmentedString: Use decrementAndCheckLength where possible (Closed)

Created:
5 years, 3 months ago by kouhei (in TOK)
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

SegmentedString: Use decrementAndCheckLength where possible This CL removes duplicated decrementAndCheckLength() logic in SegmentedString. BUG=None TESTS=Refactoring only. No change in behaviour Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201286

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M Source/platform/text/SegmentedString.h View 2 chunks +2 lines, -11 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
kouhei (in TOK)
5 years, 3 months ago (2015-08-27 03:01:24 UTC) #2
tkent
lgtm https://codereview.chromium.org/1320813002/diff/1/Source/platform/text/SegmentedString.h File Source/platform/text/SegmentedString.h (right): https://codereview.chromium.org/1320813002/diff/1/Source/platform/text/SegmentedString.h#newcode238 Source/platform/text/SegmentedString.h:238: if (haveNewLine) { This block doesn't refer to ...
5 years, 3 months ago (2015-08-27 03:08:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320813002/1
5 years, 3 months ago (2015-08-27 03:08:46 UTC) #5
blink-reviews
Thanks! On Thu, Aug 27, 2015 at 12:08 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > ...
5 years, 3 months ago (2015-08-27 03:09:44 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 05:05:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201286

Powered by Google App Engine
This is Rietveld 408576698