Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 13208002: Revert 191173 "Check in a custom-built import library for user32..." (Closed)

Created:
7 years, 9 months ago by rlarocque
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 191173 "Check in a custom-built import library for user32..." > Check in a custom-built import library for user32 exports up to Windows XP SP2/SP3, which is used by chrome.dll in preference to the Platform SDK's user32.lib import library. > Custom build an import library for Chrome's post-WinXP imports, that binds to a fictional "user32-delay.dll". > Implement and test a delay load hook that diverts dynamic loading of any dll "foo-delay.dll" to "foo.dll". > > R=cpu@chromium.org > BUG=176040 > > > Review URL: https://chromiumcodereview.appspot.com/12295040 TBR=siggi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1311 lines) Patch
D trunk/src/build/win/importlibs/create_import_lib.gypi View 1 chunk +0 lines, -55 lines 0 comments Download
D trunk/src/build/win/importlibs/create_importlib_win.py View 1 chunk +0 lines, -218 lines 0 comments Download
D trunk/src/build/win/importlibs/filter_export_list.py View 1 chunk +0 lines, -85 lines 0 comments Download
D trunk/src/build/win/importlibs/x86/user32.winxp.imports View 1 chunk +0 lines, -670 lines 0 comments Download
D trunk/src/chrome/app/delay_load_hook_unittest_win.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D trunk/src/chrome/app/delay_load_hook_win.h View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/chrome/app/delay_load_hook_win.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M trunk/src/chrome/chrome.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D trunk/src/chrome/chrome.user32.delay.imports View 1 chunk +0 lines, -29 lines 0 comments Download
M trunk/src/chrome/chrome_dll.gypi View 3 chunks +0 lines, -39 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rlarocque
7 years, 9 months ago (2013-03-28 18:37:51 UTC) #1
rlarocque
7 years, 9 months ago (2013-03-28 18:38:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r191179.

Powered by Google App Engine
This is Rietveld 408576698