content/renderer/pepper/pepper_platform_audio_output.cc - Issue 1320783002: Make SharedMemoryHandle a class on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_platform_audio_output.cc

Issue 1320783002: Make SharedMemoryHandle a class on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ipc_global

Patch Set: Fix DCHECK. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_platform_audio_output.cc

diff --git a/content/renderer/pepper/pepper_platform_audio_output.cc b/content/renderer/pepper/pepper_platform_audio_output.cc

index 010b30f75db5c87f8aa86e17c9c1f9262ad7b77d..44f85cd1db6d52e180cd89d580a786a25e16ac5d 100644

--- a/content/renderer/pepper/pepper_platform_audio_output.cc

+++ b/content/renderer/pepper/pepper_platform_audio_output.cc

@@ -77,7 +77,7 @@ void PepperPlatformAudioOutput::OnStreamCreated(

base::SyncSocket::Handle socket_handle,

int length) {

#if defined(OS_WIN)

- DCHECK(handle);

+ DCHECK(handle.IsValid());

DCHECK(socket_handle);

#else

DCHECK(base::SharedMemory::IsHandleValid(handle));