content/ppapi_plugin/ppapi_thread.cc - Issue 1320783002: Make SharedMemoryHandle a class on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 1320783002: Make SharedMemoryHandle a class on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ipc_global

Patch Set: Fix DCHECK. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/ppapi_plugin/ppapi_thread.cc

diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc

index 1618519a586b3d86901e16ed338cddf95fd05b23..db058138f3a3601c1ac5dda4e802bef80d5d1dcf 100644

--- a/content/ppapi_plugin/ppapi_thread.cc

+++ b/content/ppapi_plugin/ppapi_thread.cc

@@ -206,7 +206,10 @@ base::SharedMemoryHandle PpapiThread::ShareSharedMemoryHandleWithRemote(

#if defined(OS_WIN)

if (peer_handle_.IsValid()) {

DCHECK(is_broker_);

- return IPC::GetFileHandleForProcess(handle, peer_handle_.Get(), false);

+ IPC::PlatformFileForTransit platform_file = IPC::GetFileHandleForProcess(

+ handle.GetHandle(), peer_handle_.Get(), false);

+ base::ProcessId pid = base::GetProcId(peer_handle_.Get());

+ return base::SharedMemoryHandle(platform_file, pid);

}

#endif