Make SharedMemoryHandle a class on windows.

Make SharedMemoryHandle a class on windows.

This CL is intended to be a refactor and should not introduce any behavior
changes.

Previously, SharedMemoryhandle was typedefed to HANDLE. Making it a class allows
us to add metainformation about the process in which the HANDLE is valid. This
will be used in the future by Chrome's IPC system to automatically duplicate
HANDLEs into their destination process.

BUG=493414, 535028
Committed: https://crrev.com/5ea2ab75db847e7506f4e9e6f6b370f65cc1bb39
Cr-Commit-Position: refs/heads/master@{#350932}

[erikchen, 2015-08-28 01:42:30]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 01:43:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/60001

[commit-bot: I haz the power, 2015-08-28 01:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 01:45:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[erikchen, 2015-09-12 01:28:55]

Patchset #5 (id:80001) has been deleted

[erikchen, 2015-09-12 17:17:46]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-12 17:18:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/100001

[commit-bot: I haz the power, 2015-09-12 17:56:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 17:56:58]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[erikchen, 2015-09-14 18:04:36]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 18:06:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/120001

[commit-bot: I haz the power, 2015-09-14 18:40:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 18:40:55]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-09-18 17:19:38]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 17:20:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/140001

[commit-bot: I haz the power, 2015-09-18 17:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 17:23:41]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2015-09-18 17:42:22]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 17:42:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/160001

[commit-bot: I haz the power, 2015-09-18 18:26:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 18:26:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-09-18 20:53:22]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 20:53:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/180001

[commit-bot: I haz the power, 2015-09-18 20:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 20:56:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2015-09-18 21:14:43]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 21:15:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/200001

[commit-bot: I haz the power, 2015-09-18 22:02:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 22:02:19]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[erikchen, 2015-09-18 23:58:38]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 23:59:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/220001

[commit-bot: I haz the power, 2015-09-19 00:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-19 00:37:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-09-19 00:57:00]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-19 00:57:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/240001

[commit-bot: I haz the power, 2015-09-19 01:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-19 01:39:00]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[erikchen, 2015-09-21 20:39:16]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 20:40:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/280001

[commit-bot: I haz the power, 2015-09-21 21:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 21:22:08]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[erikchen, 2015-09-22 01:42:52]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 01:43:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/280001

[commit-bot: I haz the power, 2015-09-22 02:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 02:37:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-09-22 22:00:01]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 22:01:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/300001

[erikchen, 2015-09-23 00:06:51]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2015-09-23 00:07:06]

erikchen@chromium.org changed reviewers:
+ tsepez@chromium.org

[erikchen, 2015-09-23 00:07:06]

tsepez: Please review.

[commit-bot: I haz the power, 2015-09-23 00:08:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/320001

[commit-bot: I haz the power, 2015-09-23 03:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 03:08:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Tom Sepez, 2015-09-23 22:06:13]

https://codereview.chromium.org/1320783002/diff/320001/content/common/dwrite_...
File content/common/dwrite_font_platform_win.cc (right):

https://codereview.chromium.org/1320783002/diff/320001/content/common/dwrite_...
content/common/dwrite_font_platform_win.cc:942: reinterpret_cast<unsigned
int*>(&handle_int));
note: technically wrong, this needs to be the address of a real uint, later
check that it fits inside an int and cast to int.

https://codereview.chromium.org/1320783002/diff/320001/content/common/sandbox...
File content/common/sandbox_init_win.cc (right):

https://codereview.chromium.org/1320783002/diff/320001/content/common/sandbox...
content/common/sandbox_init_win.cc:50: bool success = BrokerDuplicateHandle(
nit: local not needed.

https://codereview.chromium.org/1320783002/diff/320001/ipc/ipc_message_utils.cc
File ipc/ipc_message_utils.cc (right):

https://codereview.chromium.org/1320783002/diff/320001/ipc/ipc_message_utils....
ipc/ipc_message_utils.cc:608: // Long on Windows is 32 bits.
nit: comment doesn't add much value as you said the same thing above.

[erikchen, 2015-09-24 00:44:18]

tsepez: PTAL

https://codereview.chromium.org/1320783002/diff/320001/content/common/dwrite_...
File content/common/dwrite_font_platform_win.cc (right):

https://codereview.chromium.org/1320783002/diff/320001/content/common/dwrite_...
content/common/dwrite_font_platform_win.cc:942: reinterpret_cast<unsigned
int*>(&handle_int));
On 2015/09/23 22:06:13, Tom Sepez wrote:
> note: technically wrong, this needs to be the address of a real uint, later
> check that it fits inside an int and cast to int.

handle_int was a poorly named variable - it was actually a uint already, and the
reinterpret cast is unnecessary. The existing code was...wrong, since it was
reinterpret_casting a HANDLE* to a uint*.

I've renamed to variable to handle_uint, and added a safety check for the
overflow case.

https://codereview.chromium.org/1320783002/diff/320001/content/common/sandbox...
File content/common/sandbox_init_win.cc (right):

https://codereview.chromium.org/1320783002/diff/320001/content/common/sandbox...
content/common/sandbox_init_win.cc:50: bool success = BrokerDuplicateHandle(
On 2015/09/23 22:06:13, Tom Sepez wrote:
> nit: local not needed.

I removed it.

https://codereview.chromium.org/1320783002/diff/320001/ipc/ipc_message_utils.cc
File ipc/ipc_message_utils.cc (right):

https://codereview.chromium.org/1320783002/diff/320001/ipc/ipc_message_utils....
ipc/ipc_message_utils.cc:608: // Long on Windows is 32 bits.
On 2015/09/23 22:06:13, Tom Sepez wrote:
> nit: comment doesn't add much value as you said the same thing above.

I removed it.

[erikchen, 2015-09-24 15:30:23]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2015-09-24 15:30:24]

thakis: Looking for a base/ review.

[Nico, 2015-09-24 15:48:54]

base lgtm

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
File base/memory/shared_memory_handle_win.cc (right):

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
base/memory/shared_memory_handle_win.cc:11:
SharedMemoryHandle::SharedMemoryHandle() : handle_(nullptr), pid_(0) {}
(i'm assuming you're aware of
http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx and that NULL
is the right choice here. looks like it's not an issue in this case from what i
can tell)

[Tom Sepez, 2015-09-24 16:15:38]

lgtm

[erikchen, 2015-09-24 16:32:42]

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
File base/memory/shared_memory_handle_win.cc (right):

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
base/memory/shared_memory_handle_win.cc:11:
SharedMemoryHandle::SharedMemoryHandle() : handle_(nullptr), pid_(0) {}
On 2015/09/24 15:48:54, Nico (traveling Tue Sep 22) wrote:
> (i'm assuming you're aware of
> http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx and that
NULL
> is the right choice here. looks like it's not an issue in this case from what
i
> can tell)

Windows is inconsistent about the value it uses to indicate "invalid HANDLE". In
Chrome code we use NULL.

[erikchen, 2015-09-24 16:36:29]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org, kbr@chromium.org, wfh@chromium.org

[erikchen, 2015-09-24 16:36:30]

wfh: Looking for a review of sandbox/win/
kbr: Looking for a review of ui/surface
avi: Looking for a review of content/ and ui/gfx (technically ui/gfx isn't mac
stuff, but it's a 1-line refactor to a test.

[erikchen, 2015-09-24 16:43:19]

erikchen@chromium.org changed reviewers:
+ erg@chromium.org, garykac@chromium.org, mseaborn@chromium.org,
piman@chromium.org, sky@chromium.org, thestig@chromium.org

[erikchen, 2015-09-24 16:43:20]

thestig: Please review components/printing/
mseaborn: Please review components/nacl/
sky: Please review components/mus/gles2/ and mojo/gles2/
piman: Please review ppapi/proxy/
garykac: Please review remoting/host/

[Ken Russell (switch to Gerrit), 2015-09-24 16:43:21]

ui/surface LGTM

[erikchen, 2015-09-24 16:44:25]

erikchen@chromium.org changed reviewers:
+ garykac@chromium.org, mseaborn@chromium.org, piman@chromium.org,
sky@chromium.org, thestig@chromium.org

[erikchen, 2015-09-24 16:44:26]

thestig: Please review components/printing/
mseaborn: Please review components/nacl/
sky: Please review components/mus/gles2/ and mojo/gles2/
piman: Please review ppapi/proxy/
garykac: Please review remoting/host/

[Nico, 2015-09-24 16:47:43]

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
File base/memory/shared_memory_handle_win.cc (right):

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
base/memory/shared_memory_handle_win.cc:11:
SharedMemoryHandle::SharedMemoryHandle() : handle_(nullptr), pid_(0) {}
On 2015/09/24 16:32:42, erikchen wrote:
> On 2015/09/24 15:48:54, Nico (traveling Tue Sep 22) wrote:
> > (i'm assuming you're aware of
> > http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx and that
> NULL
> > is the right choice here. looks like it's not an issue in this case from
what
> i
> > can tell)
> 
> Windows is inconsistent about the value it uses to indicate "invalid HANDLE".
In
> Chrome code we use NULL.

The point of the article is that INVALID_HANDLE_VALUE is -1 and NULL is 0 and
that you need to check if the functions you're calling return
INVALID_HANDLE_VALUE or NULL, lest you're checking for the wrong return value.
It's not possible to say "in chrome we use X" as it depends on what the
functions you're calling return. (Each caller to a INVALID_HANDLE_VALUE function
could convert it to NULL and shield the rest of the codebase from this
distinction, maybe that's what you're saying.)

[erikchen, 2015-09-24 16:49:28]

On 2015/09/24 16:47:43, Nico (traveling Tue Sep 22) wrote:
>
https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
> File base/memory/shared_memory_handle_win.cc (right):
> 
>
https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
> base/memory/shared_memory_handle_win.cc:11:
> SharedMemoryHandle::SharedMemoryHandle() : handle_(nullptr), pid_(0) {}
> On 2015/09/24 16:32:42, erikchen wrote:
> > On 2015/09/24 15:48:54, Nico (traveling Tue Sep 22) wrote:
> > > (i'm assuming you're aware of
> > > http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx and that
> > NULL
> > > is the right choice here. looks like it's not an issue in this case from
> what
> > i
> > > can tell)
> > 
> > Windows is inconsistent about the value it uses to indicate "invalid
HANDLE".
> In
> > Chrome code we use NULL.
> 
> The point of the article is that INVALID_HANDLE_VALUE is -1 and NULL is 0 and
> that you need to check if the functions you're calling return
> INVALID_HANDLE_VALUE or NULL, lest you're checking for the wrong return value.
> It's not possible to say "in chrome we use X" as it depends on what the
> functions you're calling return. (Each caller to a INVALID_HANDLE_VALUE
function
> could convert it to NULL and shield the rest of the codebase from this
> distinction, maybe that's what you're saying.)

That's right - sorry, I was insufficiently precise with my response.

[Mark Seaborn, 2015-09-24 17:02:39]

On 2015/09/24 16:44:26, erikchen wrote:
> mseaborn: Please review components/nacl/

LGTM

[Will Harris, 2015-09-24 17:06:06]

> wfh: Looking for a review of sandbox/win/

sandbox/win lgtm

[Avi (use Gerrit), 2015-09-24 17:52:38]

content and ui lgtm

[Lei Zhang, 2015-09-24 18:04:38]

thestig@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Lei Zhang, 2015-09-24 18:04:39]

+brucedawson since he's been touching the same code in base.

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
File base/memory/shared_memory_handle.h (right):

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
base/memory/shared_memory_handle.h:69: // The process in which |handle_| is
valid and can be used. If handle_ is
|handle_|, refer to / use in the ctor kNullProcessId instead of 0 for x-platform
consistency?

[sky, 2015-09-24 19:19:48]

LGTM

[Lei Zhang, 2015-09-24 19:24:49]

components/printing lgtm

[erikchen, 2015-09-24 20:57:38]

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
File base/memory/shared_memory_handle.h (right):

https://codereview.chromium.org/1320783002/diff/380001/base/memory/shared_mem...
base/memory/shared_memory_handle.h:69: // The process in which |handle_| is
valid and can be used. If handle_ is
On 2015/09/24 18:04:39, Lei Zhang wrote:
> |handle_|, refer to / use in the ctor kNullProcessId instead of 0 for
x-platform
> consistency? 

Done.

[piman, 2015-09-24 21:26:29]

LGTM. IWBN if eventually the posix and windows versions of SharedMemoryHandle
supported the same interface so that we wouldn't need those ifdefs.

[garykac, 2015-09-25 18:37:52]

remoting lgtm

[erikchen, 2015-09-25 19:04:51]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-09-25 19:04:51]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
avi@chromium.org, sky@chromium.org, thestig@chromium.org, tsepez@chromium.org,
thakis@chromium.org, mseaborn@chromium.org, wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/1320783002/#ps420001
(title: "Comments from thestig.")

[commit-bot: I haz the power, 2015-09-25 19:05:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/420001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/420001

[commit-bot: I haz the power, 2015-09-25 19:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 19:08:59]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2015-09-25 19:19:57]

Patchset #22 (id:440001) has been deleted

[erikchen, 2015-09-25 19:22:25]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-09-25 19:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
avi@chromium.org, sky@chromium.org, thestig@chromium.org, piman@chromium.org,
tsepez@chromium.org, thakis@chromium.org, garykac@chromium.org,
mseaborn@chromium.org, wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/1320783002/#ps460001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-09-25 19:24:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/460001

[commit-bot: I haz the power, 2015-09-25 20:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 20:31:24]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2015-09-25 20:38:20]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-09-25 20:39:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320783002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320783002/460001

[commit-bot: I haz the power, 2015-09-25 22:34:40]

Committed patchset #22 (id:460001)

[commit-bot: I haz the power, 2015-09-25 22:36:34]

Patchset 22 (id:??) landed as
https://crrev.com/5ea2ab75db847e7506f4e9e6f6b370f65cc1bb39
Cr-Commit-Position: refs/heads/master@{#350932}