Add "Show all downloads" link to download shelf....

Add "Show all downloads" link to download shelf.

BUG=14665
TEST=Download something, check that "show all downloads" text is on shelf, click it, check that the downloads tab opens.

Review URL: http://codereview.chromium.org/132073

[Nico, 2009-06-19 16:13:17]

The text view's caret shows while it is being clicked. If you know how to fix
that, I'm happy for suggestions. Else, I'll take care of that later.

[pink (ping after 24hrs), 2009-06-19 16:36:08]

http://codereview.chromium.org/132073/diff/14/1002
File chrome/browser/cocoa/download_shelf_controller.h (right):

http://codereview.chromium.org/132073/diff/14/1002#newcode18
Line 18: IBOutlet NSScrollView* showAllDownloadsLink_;
make the outlet be the NSTextView inside the scroller. This is easy to do in IB.

http://codereview.chromium.org/132073/diff/14/1003
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/132073/diff/14/1003#newcode43
Line 43: 
omit blank line

http://codereview.chromium.org/132073/diff/14/1003#newcode58
Line 58: scoped_nsobject<NSAttributedString> linkText([[NSAttributedString
alloc]
do you need to call setEditable and setSelectable as well on the textview?

[Nico, 2009-06-19 16:48:28]

http://codereview.chromium.org/132073/diff/14/1002
File chrome/browser/cocoa/download_shelf_controller.h (right):

http://codereview.chromium.org/132073/diff/14/1002#newcode18
Line 18: IBOutlet NSScrollView* showAllDownloadsLink_;
On 2009/06/19 16:36:08, pink wrote:
> make the outlet be the NSTextView inside the scroller. This is easy to do in
IB.

Indeed. Done.

http://codereview.chromium.org/132073/diff/14/1003
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/132073/diff/14/1003#newcode43
Line 43: 
On 2009/06/19 16:36:08, pink wrote:
> omit blank line

Done.

http://codereview.chromium.org/132073/diff/14/1003#newcode58
Line 58: scoped_nsobject<NSAttributedString> linkText([[NSAttributedString
alloc]
On 2009/06/19 16:36:08, pink wrote:
> do you need to call setEditable and setSelectable as well on the textview?

Did that in IB already (selectable has to be set to true though; else the link
is not clickable).

[pink (ping after 24hrs), 2009-06-19 17:34:58]

LGTM, UI grumbling aside :-)