Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1320683003: Move logic to figure out if a socket can be reused into HttpStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index accad7da16fc38fe9be8d00e0f6394985b61992b..29788f5566eb58bfde7fb2ae7aac7a7fcfa33db6 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -13349,8 +13349,6 @@ class FakeStream : public HttpStream,
return false;
}
- bool CanFindEndOfResponse() const override { return false; }
-
bool IsConnectionReused() const override {
ADD_FAILURE();
return false;
@@ -13358,10 +13356,7 @@ class FakeStream : public HttpStream,
void SetConnectionReused() override { ADD_FAILURE(); }
- bool IsConnectionReusable() const override {
- ADD_FAILURE();
- return false;
- }
+ bool CanReuseConnection() const override { return false; }
int64 GetTotalReceivedBytes() const override {
ADD_FAILURE();
@@ -13379,11 +13374,6 @@ class FakeStream : public HttpStream,
ADD_FAILURE();
}
- bool IsSpdyHttpStream() const override {
- ADD_FAILURE();
- return false;
- }
-
void Drain(HttpNetworkSession* session) override { ADD_FAILURE(); }
void SetPriority(RequestPriority priority) override { priority_ = priority; }
@@ -13571,20 +13561,13 @@ class FakeWebSocketBasicHandshakeStream : public WebSocketHandshakeStreamBase {
return false;
}
- bool CanFindEndOfResponse() const override {
- return parser()->CanFindEndOfResponse();
- }
-
bool IsConnectionReused() const override {
NOTREACHED();
return false;
}
void SetConnectionReused() override { NOTREACHED(); }
- bool IsConnectionReusable() const override {
- NOTREACHED();
- return false;
- }
+ bool CanReuseConnection() const override { return false; }
int64 GetTotalReceivedBytes() const override {
NOTREACHED();
@@ -13602,11 +13585,6 @@ class FakeWebSocketBasicHandshakeStream : public WebSocketHandshakeStreamBase {
NOTREACHED();
}
- bool IsSpdyHttpStream() const override {
- NOTREACHED();
- return false;
- }
-
void Drain(HttpNetworkSession* session) override { NOTREACHED(); }
void SetPriority(RequestPriority priority) override { NOTREACHED(); }

Powered by Google App Engine
This is Rietveld 408576698