Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: chrome/browser/extensions/api/content_settings/content_settings_api.cc

Issue 1320673013: Remove HostContentSettingsMap::IsSettingAllowedForType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-issetting-allowed
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/content_settings/content_settings_api.h" 5 #include "chrome/browser/extensions/api/content_settings/content_settings_api.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "chrome/browser/content_settings/cookie_settings_factory.h" 15 #include "chrome/browser/content_settings/cookie_settings_factory.h"
16 #include "chrome/browser/content_settings/host_content_settings_map_factory.h" 16 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
17 #include "chrome/browser/extensions/api/content_settings/content_settings_api_co nstants.h" 17 #include "chrome/browser/extensions/api/content_settings/content_settings_api_co nstants.h"
18 #include "chrome/browser/extensions/api/content_settings/content_settings_helper s.h" 18 #include "chrome/browser/extensions/api/content_settings/content_settings_helper s.h"
19 #include "chrome/browser/extensions/api/content_settings/content_settings_servic e.h" 19 #include "chrome/browser/extensions/api/content_settings/content_settings_servic e.h"
20 #include "chrome/browser/extensions/api/content_settings/content_settings_store. h" 20 #include "chrome/browser/extensions/api/content_settings/content_settings_store. h"
21 #include "chrome/browser/extensions/api/preference/preference_api_constants.h" 21 #include "chrome/browser/extensions/api/preference/preference_api_constants.h"
22 #include "chrome/browser/extensions/api/preference/preference_helpers.h" 22 #include "chrome/browser/extensions/api/preference/preference_helpers.h"
23 #include "chrome/browser/plugins/plugin_finder.h" 23 #include "chrome/browser/plugins/plugin_finder.h"
24 #include "chrome/browser/plugins/plugin_installer.h" 24 #include "chrome/browser/plugins/plugin_installer.h"
25 #include "chrome/browser/profiles/profile.h" 25 #include "chrome/browser/profiles/profile.h"
26 #include "chrome/common/chrome_switches.h" 26 #include "chrome/common/chrome_switches.h"
27 #include "chrome/common/extensions/api/content_settings.h" 27 #include "chrome/common/extensions/api/content_settings.h"
28 #include "components/content_settings/core/browser/content_settings_info.h"
29 #include "components/content_settings/core/browser/content_settings_registry.h"
28 #include "components/content_settings/core/browser/content_settings_utils.h" 30 #include "components/content_settings/core/browser/content_settings_utils.h"
29 #include "components/content_settings/core/browser/cookie_settings.h" 31 #include "components/content_settings/core/browser/cookie_settings.h"
30 #include "components/content_settings/core/browser/host_content_settings_map.h" 32 #include "components/content_settings/core/browser/host_content_settings_map.h"
31 #include "content/public/browser/plugin_service.h" 33 #include "content/public/browser/plugin_service.h"
32 #include "extensions/browser/extension_prefs_scope.h" 34 #include "extensions/browser/extension_prefs_scope.h"
33 #include "extensions/common/error_utils.h" 35 #include "extensions/common/error_utils.h"
34 36
35 using content::BrowserThread; 37 using content::BrowserThread;
36 using content::PluginService; 38 using content::PluginService;
37 39
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 std::string resource_identifier; 207 std::string resource_identifier;
206 if (params->details.resource_identifier.get()) 208 if (params->details.resource_identifier.get())
207 resource_identifier = params->details.resource_identifier->id; 209 resource_identifier = params->details.resource_identifier->id;
208 210
209 std::string setting_str; 211 std::string setting_str;
210 EXTENSION_FUNCTION_VALIDATE( 212 EXTENSION_FUNCTION_VALIDATE(
211 params->details.setting->GetAsString(&setting_str)); 213 params->details.setting->GetAsString(&setting_str));
212 ContentSetting setting; 214 ContentSetting setting;
213 EXTENSION_FUNCTION_VALIDATE( 215 EXTENSION_FUNCTION_VALIDATE(
214 content_settings::ContentSettingFromString(setting_str, &setting)); 216 content_settings::ContentSettingFromString(setting_str, &setting));
215 EXTENSION_FUNCTION_VALIDATE(HostContentSettingsMap::IsSettingAllowedForType( 217 EXTENSION_FUNCTION_VALIDATE(
216 GetProfile()->GetPrefs(), setting, content_type)); 218 content_settings::ContentSettingsRegistry::GetInstance()
219 ->Get(content_type)
220 ->IsSettingValid(setting));
217 221
218 // Some content setting types support the full set of values listed in 222 // Some content setting types support the full set of values listed in
219 // content_settings.json only for exceptions. For the default setting, 223 // content_settings.json only for exceptions. For the default setting,
220 // some values might not be supported. 224 // some values might not be supported.
221 // For example, camera supports [allow, ask, block] for exceptions, but only 225 // For example, camera supports [allow, ask, block] for exceptions, but only
222 // [ask, block] for the default setting. 226 // [ask, block] for the default setting.
223 if (primary_pattern == ContentSettingsPattern::Wildcard() && 227 if (primary_pattern == ContentSettingsPattern::Wildcard() &&
224 secondary_pattern == ContentSettingsPattern::Wildcard() && 228 secondary_pattern == ContentSettingsPattern::Wildcard() &&
225 !HostContentSettingsMap::IsDefaultSettingAllowedForType( 229 !HostContentSettingsMap::IsDefaultSettingAllowedForType(setting,
226 GetProfile()->GetPrefs(), setting, content_type)) { 230 content_type)) {
227 static const char kUnsupportedDefaultSettingError[] = 231 static const char kUnsupportedDefaultSettingError[] =
228 "'%s' is not supported as the default setting of %s."; 232 "'%s' is not supported as the default setting of %s.";
229 233
230 // TODO(msramek): Get the same human readable name as is presented 234 // TODO(msramek): Get the same human readable name as is presented
231 // externally in the API, i.e. chrome.contentSettings.<name>.set(). 235 // externally in the API, i.e. chrome.contentSettings.<name>.set().
232 std::string readable_type_name; 236 std::string readable_type_name;
233 switch (content_type) { 237 switch (content_type) {
234 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC: 238 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
235 readable_type_name = "microphone"; 239 readable_type_name = "microphone";
236 break; 240 break;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 SetResult(list); 326 SetResult(list);
323 BrowserThread::PostTask( 327 BrowserThread::PostTask(
324 BrowserThread::UI, FROM_HERE, base::Bind( 328 BrowserThread::UI, FROM_HERE, base::Bind(
325 &ContentSettingsContentSettingGetResourceIdentifiersFunction:: 329 &ContentSettingsContentSettingGetResourceIdentifiersFunction::
326 SendResponse, 330 SendResponse,
327 this, 331 this,
328 true)); 332 true));
329 } 333 }
330 334
331 } // namespace extensions 335 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698