Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: chrome/browser/extensions/api/content_settings/content_settings_api.cc

Issue 1320673013: Remove HostContentSettingsMap::IsSettingAllowedForType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-issetting-allowed
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/content_settings/content_settings_api.h" 5 #include "chrome/browser/extensions/api/content_settings/content_settings_api.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "chrome/browser/content_settings/cookie_settings_factory.h" 15 #include "chrome/browser/content_settings/cookie_settings_factory.h"
16 #include "chrome/browser/content_settings/host_content_settings_map_factory.h" 16 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
17 #include "chrome/browser/extensions/api/content_settings/content_settings_api_co nstants.h" 17 #include "chrome/browser/extensions/api/content_settings/content_settings_api_co nstants.h"
18 #include "chrome/browser/extensions/api/content_settings/content_settings_helper s.h" 18 #include "chrome/browser/extensions/api/content_settings/content_settings_helper s.h"
19 #include "chrome/browser/extensions/api/content_settings/content_settings_servic e.h" 19 #include "chrome/browser/extensions/api/content_settings/content_settings_servic e.h"
20 #include "chrome/browser/extensions/api/content_settings/content_settings_store. h" 20 #include "chrome/browser/extensions/api/content_settings/content_settings_store. h"
21 #include "chrome/browser/extensions/api/preference/preference_api_constants.h" 21 #include "chrome/browser/extensions/api/preference/preference_api_constants.h"
22 #include "chrome/browser/extensions/api/preference/preference_helpers.h" 22 #include "chrome/browser/extensions/api/preference/preference_helpers.h"
23 #include "chrome/browser/plugins/plugin_finder.h" 23 #include "chrome/browser/plugins/plugin_finder.h"
24 #include "chrome/browser/plugins/plugin_installer.h" 24 #include "chrome/browser/plugins/plugin_installer.h"
25 #include "chrome/browser/profiles/profile.h" 25 #include "chrome/browser/profiles/profile.h"
26 #include "chrome/common/chrome_switches.h" 26 #include "chrome/common/chrome_switches.h"
27 #include "chrome/common/extensions/api/content_settings.h" 27 #include "chrome/common/extensions/api/content_settings.h"
28 #include "components/content_settings/core/browser/content_settings_info.h"
29 #include "components/content_settings/core/browser/content_settings_registry.h"
28 #include "components/content_settings/core/browser/cookie_settings.h" 30 #include "components/content_settings/core/browser/cookie_settings.h"
29 #include "components/content_settings/core/browser/host_content_settings_map.h" 31 #include "components/content_settings/core/browser/host_content_settings_map.h"
30 #include "content/public/browser/plugin_service.h" 32 #include "content/public/browser/plugin_service.h"
31 #include "extensions/browser/extension_prefs_scope.h" 33 #include "extensions/browser/extension_prefs_scope.h"
32 #include "extensions/common/error_utils.h" 34 #include "extensions/common/error_utils.h"
33 35
34 using content::BrowserThread; 36 using content::BrowserThread;
35 using content::PluginService; 37 using content::PluginService;
36 38
37 namespace Clear = extensions::api::content_settings::ContentSetting::Clear; 39 namespace Clear = extensions::api::content_settings::ContentSetting::Clear;
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 std::string resource_identifier; 204 std::string resource_identifier;
203 if (params->details.resource_identifier.get()) 205 if (params->details.resource_identifier.get())
204 resource_identifier = params->details.resource_identifier->id; 206 resource_identifier = params->details.resource_identifier->id;
205 207
206 std::string setting_str; 208 std::string setting_str;
207 EXTENSION_FUNCTION_VALIDATE( 209 EXTENSION_FUNCTION_VALIDATE(
208 params->details.setting->GetAsString(&setting_str)); 210 params->details.setting->GetAsString(&setting_str));
209 ContentSetting setting; 211 ContentSetting setting;
210 EXTENSION_FUNCTION_VALIDATE( 212 EXTENSION_FUNCTION_VALIDATE(
211 helpers::StringToContentSetting(setting_str, &setting)); 213 helpers::StringToContentSetting(setting_str, &setting));
212 EXTENSION_FUNCTION_VALIDATE(HostContentSettingsMap::IsSettingAllowedForType( 214 EXTENSION_FUNCTION_VALIDATE(
213 GetProfile()->GetPrefs(), setting, content_type)); 215 content_settings::ContentSettingsRegistry::GetInstance()
216 ->Get(content_type)
217 ->IsSettingValid(setting));
214 218
215 // Some content setting types support the full set of values listed in 219 // Some content setting types support the full set of values listed in
216 // content_settings.json only for exceptions. For the default setting, 220 // content_settings.json only for exceptions. For the default setting,
217 // some values might not be supported. 221 // some values might not be supported.
218 // For example, camera supports [allow, ask, block] for exceptions, but only 222 // For example, camera supports [allow, ask, block] for exceptions, but only
219 // [ask, block] for the default setting. 223 // [ask, block] for the default setting.
220 if (primary_pattern == ContentSettingsPattern::Wildcard() && 224 if (primary_pattern == ContentSettingsPattern::Wildcard() &&
221 secondary_pattern == ContentSettingsPattern::Wildcard() && 225 secondary_pattern == ContentSettingsPattern::Wildcard() &&
222 !HostContentSettingsMap::IsDefaultSettingAllowedForType( 226 !HostContentSettingsMap::IsDefaultSettingAllowedForType(setting,
223 GetProfile()->GetPrefs(), setting, content_type)) { 227 content_type)) {
224 static const char kUnsupportedDefaultSettingError[] = 228 static const char kUnsupportedDefaultSettingError[] =
225 "'%s' is not supported as the default setting of %s."; 229 "'%s' is not supported as the default setting of %s.";
226 230
227 // TODO(msramek): Get the same human readable name as is presented 231 // TODO(msramek): Get the same human readable name as is presented
228 // externally in the API, i.e. chrome.contentSettings.<name>.set(). 232 // externally in the API, i.e. chrome.contentSettings.<name>.set().
229 std::string readable_type_name; 233 std::string readable_type_name;
230 switch (content_type) { 234 switch (content_type) {
231 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC: 235 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
232 readable_type_name = "microphone"; 236 readable_type_name = "microphone";
233 break; 237 break;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 SetResult(list); 323 SetResult(list);
320 BrowserThread::PostTask( 324 BrowserThread::PostTask(
321 BrowserThread::UI, FROM_HERE, base::Bind( 325 BrowserThread::UI, FROM_HERE, base::Bind(
322 &ContentSettingsContentSettingGetResourceIdentifiersFunction:: 326 &ContentSettingsContentSettingGetResourceIdentifiersFunction::
323 SendResponse, 327 SendResponse,
324 this, 328 this,
325 true)); 329 true));
326 } 330 }
327 331
328 } // namespace extensions 332 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698