Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1320673007: Disallow yield in default parameter initializers (Closed)

Created:
5 years, 3 months ago by wingo
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disallow yield in default parameter initializers R=adamk@chromium.org LOG=N BUG=v8:4397 Committed: https://crrev.com/a9d24d3f61baaa170f71dd1ff2d5a5a154166b47 Cr-Commit-Position: refs/heads/master@{#30431}

Patch Set 1 #

Patch Set 2 : Fix formatting #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -11 lines) Patch
M src/expression-classifier.h View 1 2 6 chunks +33 lines, -8 lines 0 comments Download
M src/preparser.h View 1 2 8 chunks +24 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
wingo
5 years, 3 months ago (2015-08-27 16:45:06 UTC) #1
adamk
lgtm
5 years, 3 months ago (2015-08-27 19:09:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320673007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320673007/20001
5 years, 3 months ago (2015-08-28 08:00:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3802)
5 years, 3 months ago (2015-08-28 08:01:39 UTC) #7
wingo
Rebased. While looking at the diff I noticed a place I did a ValidateFormalParameterInitializer(classifier, ok), ...
5 years, 3 months ago (2015-08-28 08:17:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320673007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320673007/40001
5 years, 3 months ago (2015-08-28 08:17:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-28 08:44:24 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 08:44:42 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a9d24d3f61baaa170f71dd1ff2d5a5a154166b47
Cr-Commit-Position: refs/heads/master@{#30431}

Powered by Google App Engine
This is Rietveld 408576698