Issue 132063006: Point out in the comments the equivalence of two observer functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132063006: Point out in the comments the equivalence of two observer functions. (Closed)

Created:
6 years, 11 months ago by Avi (use Gerrit)

Modified:
6 years, 11 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Point out in the comments the equivalence of two observer functions. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244127

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	content/public/browser/render_process_host_observer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/public/browser/web_contents_observer.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/132063006/1

6 years, 11 months ago (2014-01-09 22:41:10 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=111361

6 years, 11 months ago (2014-01-10 00:51:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/132063006/1

6 years, 11 months ago (2014-01-10 07:12:18 UTC) #5

Message was sent while issue was closed.

Change committed as 244127

Expand Messages | Collapse Messages