Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1320623004: [turbofan] Fix type feedback vector for stub compilation. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix type feedback vector for stub compilation. This makes sure that stubs never get to see a type feedback vector, which would be an empty fixed array anyways, but takes whatever the given CompilationInfo provides. R=mvstanton@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-27 13:47:05 UTC) #1
mvstanton
Smart to do. LGTM.
5 years, 3 months ago (2015-08-27 13:47:45 UTC) #2
Michael Starzinger
4 years, 6 months ago (2016-06-13 11:46:24 UTC) #3
This is no longer needed now that the compilation pipeline has been straightened
out. Also, stub compilation no longer goes through the AST graph builder.
Closing.

Powered by Google App Engine
This is Rietveld 408576698