Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2065)

Unified Diff: cc/resources/tile_manager.cc

Issue 13206004: cc: Fix build issues for adding ‘chromium_code’: 1 to cc.gyp and cc_tests.gyp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/scoped_resource_unittest.cc ('k') | cc/scheduler/frame_rate_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/tile_manager.cc
diff --git a/cc/resources/tile_manager.cc b/cc/resources/tile_manager.cc
index ed00374c77b4d8336305b8b2774378b1d8be0c84..47b7f3613b24c894caa55a848e29a4b58c5b9822 100644
--- a/cc/resources/tile_manager.cc
+++ b/cc/resources/tile_manager.cc
@@ -31,12 +31,12 @@ namespace {
#if defined(OS_ANDROID)
// For reference, the Nexus10 can upload 1MB in about 2.5ms.
// Assuming a three frame deep pipeline this implies ~20MB.
-const int kMaxPendingUploadBytes = 20 * 1024 * 1024;
+const size_t kMaxPendingUploadBytes = 20 * 1024 * 1024;
// TODO(epenner): We should remove this upload limit (crbug.com/176197)
-const int kMaxPendingUploads = 72;
+const size_t kMaxPendingUploads = 72;
#else
-const int kMaxPendingUploadBytes = 100 * 1024 * 1024;
-const int kMaxPendingUploads = 1000;
+const size_t kMaxPendingUploadBytes = 100 * 1024 * 1024;
+const size_t kMaxPendingUploads = 1000;
#endif
#if defined(OS_ANDROID)
@@ -165,14 +165,14 @@ TileManager::TileManager(
bytes_pending_upload_(0),
has_performed_uploads_since_last_flush_(false),
ever_exceeded_memory_budget_(false),
+ rendering_stats_instrumentation_(rendering_stats_instrumentation),
max_prepaint_tile_distance_(max_prepaint_tile_distance),
use_cheapness_estimator_(use_cheapness_estimator),
use_color_estimator_(use_color_estimator),
prediction_benchmarking_(prediction_benchmarking),
did_initialize_visible_tile_(false),
pending_tasks_(0),
- max_pending_tasks_(kMaxNumPendingTasksPerThread * num_raster_threads),
- rendering_stats_instrumentation_(rendering_stats_instrumentation) {
+ max_pending_tasks_(kMaxNumPendingTasksPerThread * num_raster_threads) {
for (int i = 0; i < NUM_STATES; ++i) {
for (int j = 0; j < NUM_TREES; ++j) {
for (int k = 0; k < NUM_BINS; ++k)
@@ -190,9 +190,9 @@ TileManager::~TileManager() {
// resources.
raster_worker_pool_.reset();
AbortPendingTileUploads();
- DCHECK_EQ(tiles_with_pending_upload_.size(), 0);
- DCHECK_EQ(all_tiles_.size(), 0);
- DCHECK_EQ(live_or_allocated_tiles_.size(), 0);
+ DCHECK_EQ(0u, tiles_with_pending_upload_.size());
+ DCHECK_EQ(0u, all_tiles_.size());
+ DCHECK_EQ(0u, live_or_allocated_tiles_.size());
}
void TileManager::SetGlobalState(
@@ -1034,7 +1034,7 @@ void TileManager::RunRasterTask(
RecordCheapnessPredictorResults(is_predicted_cheap, is_actually_cheap);
DCHECK_EQ(bitmap.rowBytes(),
- bitmap.width() * bitmap.bytesPerPixel());
+ static_cast<size_t>(bitmap.width() * bitmap.bytesPerPixel()));
RecordSolidColorPredictorResults(
reinterpret_cast<SkColor*>(bitmap.getPixels()),
« no previous file with comments | « cc/resources/scoped_resource_unittest.cc ('k') | cc/scheduler/frame_rate_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698