Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: chrome/browser/ui/views/new_task_manager_view.h

Issue 1320563002: Task Manager Should remember the most recently enabled columns. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: thestig's comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/new_task_manager_view.h
diff --git a/chrome/browser/ui/views/new_task_manager_view.h b/chrome/browser/ui/views/new_task_manager_view.h
index 2d4d03884030377fc9ba756eb30c3e3956af58c8..4efc42089b01730830858dbc6319cae9b4575dda 100644
--- a/chrome/browser/ui/views/new_task_manager_view.h
+++ b/chrome/browser/ui/views/new_task_manager_view.h
@@ -101,10 +101,27 @@ class NewTaskManagerView
// Restores saved "always on top" state from a previous session.
void RetriveSavedAlwaysOnTopState();
+ // Restores the saved columns settings from a previous session.
+ void RetrieveSavedColumnsSettings();
+
+ // Updates the table view based on the values currently stored in
Lei Zhang 2015/08/28 22:47:45 nit: extra space before "stored"
afakhry 2015/08/29 00:30:30 Done.
+ // |columns_settings_|.
+ void UpdateTableFromColumnsSettings();
+
+ // Stores the current values in |column_settings_| to the user prefs so that
+ // it can be restored later next time the task manager view is opened.
+ void StoreColumnsSettings();
+
scoped_ptr<NewTaskManagerView::TableModel> table_model_;
scoped_ptr<views::MenuRunner> menu_runner_;
+ // Contains either the retrieved from user preferences columns settings if
Lei Zhang 2015/08/28 22:47:45 I have a bit of trouble parsing this sentence. How
afakhry 2015/08/29 00:30:30 Done.
+ // any, or it will contain the default columns settings.
+ // The columns settings are the visible columns and the last sorted column
+ // and the direction of the sort.
+ scoped_ptr<base::DictionaryValue> columns_settings_;
+
// We need to own the text of the menu, the Windows API does not copy it.
base::string16 always_on_top_menu_text_;

Powered by Google App Engine
This is Rietveld 408576698