Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/task_management/providers/child_process_task_provider.cc

Issue 1320563002: Task Manager Should remember the most recently enabled columns. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tearing Down Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/task_manager/task_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_management/providers/child_process_task_provider.cc
diff --git a/chrome/browser/task_management/providers/child_process_task_provider.cc b/chrome/browser/task_management/providers/child_process_task_provider.cc
index a6f2073a13280e0b396c10d7ec2446256927361f..ca00a514b022f2382c3abeabbc3519c152b7fa2d 100644
--- a/chrome/browser/task_management/providers/child_process_task_provider.cc
+++ b/chrome/browser/task_management/providers/child_process_task_provider.cc
@@ -123,12 +123,10 @@ void ChildProcessTaskProvider::ChildProcessDataCollected(
void ChildProcessTaskProvider::CreateTask(
const content::ChildProcessData& data) {
- // The following case should never happen since we start observing
- // |BrowserChildProcessObserver| only after we collect all pre-existing child
- // processes and are notified (on the UI thread) that the collection is
- // completed at |ChildProcessDataCollected()|.
if (tasks_by_handle_.find(data.handle) != tasks_by_handle_.end()) {
- NOTREACHED();
+ // This case can happen when some of the child process data we collect upon
+ // StartUpdating() might be of BrowserChildProcessHosts whose channels
+ // hadn't connected yet. So we just return.
return;
}
« no previous file with comments | « no previous file | chrome/browser/task_manager/task_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698