Issue 1320543003: Simplify RenderedPosition constructor with VisiblePosition parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320543003: Simplify RenderedPosition constructor with VisiblePosition parameter (Closed)

Created:
5 years, 3 months ago by yosin_UTC9

Modified:
5 years, 3 months ago

Reviewers:
yoichio, hajimehoshi

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplify RenderedPosition constructor with VisiblePosition parameter This patch makes |RenderedPosition| constructor with |VisiblePosition| parameter simpler by using delegating constructor for improving code helath. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201300

Patch Set 1 : 2015-08-27T16:44:57 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -14 lines)			Patch
	M	Source/core/editing/RenderedPosition.cpp	View		1 chunk	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320543003/1

5 years, 3 months ago (2015-08-27 08:10:36 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-08-27 09:18:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201300

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages