Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 1320543002: DevTools: simplify & fix property overload logic (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/StylesSidebarPane.js
diff --git a/Source/devtools/front_end/elements/StylesSidebarPane.js b/Source/devtools/front_end/elements/StylesSidebarPane.js
index 0fac3189be4c8911aa19f37eee3a1e9d00cc2f5a..4f13bd6f2490ee7b24b853c4a587d991071bf722 100644
--- a/Source/devtools/front_end/elements/StylesSidebarPane.js
+++ b/Source/devtools/front_end/elements/StylesSidebarPane.js
@@ -1269,7 +1269,7 @@ WebInspector.StylePropertiesSection.prototype = {
} else {
var child = this.propertiesTreeOutline.firstChild();
while (child) {
- child.setOverloaded(this.styleRule.isPropertyOverloaded(child.name, child.isShorthand));
+ child.setOverloaded(this.styleRule.isPropertyOverloaded(child.name));
child = child.traverseNextTreeElement(false, null, true);
}
}
@@ -1295,7 +1295,7 @@ WebInspector.StylePropertiesSection.prototype = {
for (var property of style.leadingProperties()) {
var isShorthand = !!WebInspector.CSSMetadata.cssPropertiesMetainfo.longhands(property.name);
var inherited = this.isPropertyInherited(property.name);
- var overloaded = this.styleRule.isPropertyOverloaded(property.name, isShorthand);
+ var overloaded = this.styleRule.isPropertyOverloaded(property.name);
var item = new WebInspector.StylePropertyTreeElement(this._parentPane, this.styleRule, property, isShorthand, inherited, overloaded);
this.propertiesTreeOutline.appendChild(item);
}

Powered by Google App Engine
This is Rietveld 408576698