Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1320543002: DevTools: simplify & fix property overload logic (Closed)

Created:
5 years, 4 months ago by lushnikov
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: simplify & fix property overload logic - Simplify StyleSectionModel.isPropertyOverloaded method. It does not require a second parameter any more. - As a side effect of previous bullet, fix a bug and add a test. - Centralize all logic of computing used properties in a single place. BUG=496263 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201190

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -32 lines) Patch
A LayoutTests/inspector/elements/styles-4/styles-properties-overload.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/styles-4/styles-properties-overload-expected.txt View 1 chunk +52 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSectionModel.js View 2 chunks +23 lines, -29 lines 2 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
lushnikov
ptal
5 years, 4 months ago (2015-08-26 00:00:26 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/1320543002/diff/1/Source/devtools/front_end/elements/StylesSectionModel.js File Source/devtools/front_end/elements/StylesSectionModel.js (right): https://codereview.chromium.org/1320543002/diff/1/Source/devtools/front_end/elements/StylesSectionModel.js#newcode340 Source/devtools/front_end/elements/StylesSectionModel.js:340: for (var property of style.leadingProperties()) { I think ...
5 years, 4 months ago (2015-08-26 01:32:38 UTC) #2
lushnikov
https://codereview.chromium.org/1320543002/diff/1/Source/devtools/front_end/elements/StylesSectionModel.js File Source/devtools/front_end/elements/StylesSectionModel.js (right): https://codereview.chromium.org/1320543002/diff/1/Source/devtools/front_end/elements/StylesSectionModel.js#newcode340 Source/devtools/front_end/elements/StylesSectionModel.js:340: for (var property of style.leadingProperties()) { We will still ...
5 years, 4 months ago (2015-08-26 01:35:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320543002/1
5 years, 4 months ago (2015-08-26 01:36:06 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 03:04:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201190

Powered by Google App Engine
This is Rietveld 408576698