Issue 132053003: Android: Fix double free in DeviceController (forwarder2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132053003: Android: Fix double free in DeviceController (forwarder2). (Closed)

Created:
6 years, 11 months ago by Philippe

Modified:
6 years, 11 months ago

Reviewers:
bulach

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix double free in DeviceController (forwarder2). This happened in an error code path rarely exercised which is why it didn't show up very often. BUG=332403 R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244149

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	tools/android/forwarder2/device_controller.cc	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Philippe

Hi Marcus, It's quite a shame that I had missed this :/ But anyway this ...

6 years, 11 months ago (2014-01-09 16:46:19 UTC) #1

bulach

lgtm, thanks! on the description, s/exerced/exercised/, and may want to add "Android: " prefix..

6 years, 11 months ago (2014-01-09 16:52:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/132053003/90001

6 years, 11 months ago (2014-01-10 10:26:35 UTC) #4

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44297

6 years, 11 months ago (2014-01-10 10:47:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r244149.

Expand Messages | Collapse Messages