Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 132053002: Use truncation, not rounding, when converting perlin noise seed (required by SVG spec). (Closed)

Created:
6 years, 11 months ago by Stephen White
Modified:
6 years, 11 months ago
Reviewers:
sugoi1, sugoi, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use truncation, not rounding, when converting perlin noise seed (required by SVG spec). BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12995

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/effects/SkPerlinNoiseShader.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Stephen White
sugoi@: PTAL. Thanks!
6 years, 11 months ago (2014-01-09 16:29:13 UTC) #1
sugoi
On 2014/01/09 16:29:13, Stephen White wrote: > sugoi@: PTAL. Thanks! lgtm
6 years, 11 months ago (2014-01-09 16:30:44 UTC) #2
reed1
since this is non-obvious (obviously), lets add a comment above the call to floor/trunc that ...
6 years, 11 months ago (2014-01-09 16:33:47 UTC) #3
reed1
hmm, is the spec for trunc or floor?
6 years, 11 months ago (2014-01-09 16:34:18 UTC) #4
Stephen White
On 2014/01/09 16:34:18, reed1 wrote: > hmm, is the spec for trunc or floor? From ...
6 years, 11 months ago (2014-01-09 16:50:56 UTC) #5
Stephen White
On 2014/01/09 16:33:47, reed1 wrote: > since this is non-obvious (obviously), lets add a comment ...
6 years, 11 months ago (2014-01-09 17:28:45 UTC) #6
reed1
lgtm
6 years, 11 months ago (2014-01-09 17:40:28 UTC) #7
Stephen White
6 years, 11 months ago (2014-01-09 17:41:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r12995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698