Issue 1320513003: Merge 201139 "Use Document of callingWindow for access check in ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320513003: Merge 201139 "Use Document of callingWindow for access check in ..." (Closed)

Created:
5 years, 4 months ago by Nate Chapin

Modified:
5 years, 4 months ago

Reviewers:
Nate Chapin

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2454/

Project:
SWITCH_TO_GIT_ALREADY

Visibility:
Public.

More Reviews

Description

Merge 201139 "Use Document of callingWindow for access check in ..." > Use Document of callingWindow for access check in isInsecureScriptAccess() > > The Document call was changed to Frame::securityContext() to make the code more > RemoteFrame-friendly. However, callingWindow is guaranteed local. Revert to > getting the SecurityOrigin via Document. > > BUG=524074 > TEST=http/tests/security/location-change-from-detached-DOMWindow.html > > Review URL: https://codereview.chromium.org/1311253005 TBR=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201159

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-1 lines, --1 lines)			Patch
A +	LayoutTests/http/tests/security/location-change-from-detached-DOMWindow.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/http/tests/security/location-change-from-detached-DOMWindow-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/frame/DOMWindow.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r201159.

Expand Messages | Collapse Messages