Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1320503005: Revert of Turn VariationsService::GetVariationsServerURL into instance method (Closed)

Created:
5 years, 3 months ago by blundell
Modified:
5 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn VariationsService::GetVariationsServerURL into instance method (patchset #2 id:20001 of https://codereview.chromium.org/1312423003/ ) Reason for revert: It turns out that this change is actually not safe as written: g_browser_process->variations_service() returns null in non-official builds unless a default variations server URL is set on the command line. The reason the patch did not fail is because the method being called was (a) not virtual and (b) didn't use any state of the object. Original issue's description: > Turn VariationsService::GetVariationsServerURL into instance method > > This will allow for followup work that uses |client_| within that > method. > > BUG=516678 > TBR=bartfab > > Committed: https://crrev.com/642578a171c7acee3de6b514bf2738fcb0339aac > Cr-Commit-Position: refs/heads/master@{#346111} TBR=asvitkine@chromium.org,bartfab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516678 Committed: https://crrev.com/aaececbc843b418e0e19b78ba77bba8d7ac84a26 Cr-Commit-Position: refs/heads/master@{#346141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blundell
Created Revert of Turn VariationsService::GetVariationsServerURL into instance method
5 years, 3 months ago (2015-08-28 14:21:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320503005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320503005/1
5 years, 3 months ago (2015-08-28 14:21:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 14:22:30 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 14:23:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaececbc843b418e0e19b78ba77bba8d7ac84a26
Cr-Commit-Position: refs/heads/master@{#346141}

Powered by Google App Engine
This is Rietveld 408576698