Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1320503004: [heap] Move IdentityMap data structure out of heap. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
titzer, rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move IdentityMap data structure out of heap. This data structure uses the public heap API only and is not specific to any heap internals. It should be usable throughout V8 and inclusion of the header file should not be restricted. R=titzer@chromium.org Committed: https://crrev.com/3d7a34b5c744065a4e786645fe834ce30725c5fb Cr-Commit-Position: refs/heads/master@{#30443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -298 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D src/heap/identity-map.h View 1 chunk +0 lines, -98 lines 0 comments Download
D src/heap/identity-map.cc View 1 chunk +0 lines, -191 lines 0 comments Download
A + src/identity-map.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/identity-map.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-identity-map.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Ben: PTAL. Ross: FYI.
5 years, 3 months ago (2015-08-28 11:54:47 UTC) #2
titzer
On 2015/08/28 11:54:47, Michael Starzinger wrote: > Ben: PTAL. > Ross: FYI. LGTM
5 years, 3 months ago (2015-08-28 12:04:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320503004/1
5 years, 3 months ago (2015-08-28 12:05:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 13:01:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3d7a34b5c744065a4e786645fe834ce30725c5fb Cr-Commit-Position: refs/heads/master@{#30443}
5 years, 3 months ago (2015-08-28 13:01:18 UTC) #7
rmcilroy
5 years, 3 months ago (2015-08-28 13:11:03 UTC) #8
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698