Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3795)

Unified Diff: chrome/browser/tab_contents/tab_contents_view_gtk.h

Issue 132047: GTK: HTTP Auth dialogs under linux. (Closed)
Patch Set: Fix for evanm Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents_view_gtk.h
diff --git a/chrome/browser/tab_contents/tab_contents_view_gtk.h b/chrome/browser/tab_contents/tab_contents_view_gtk.h
index 8c85421e06b87e21f8366a2a0a039a035b8828f0..74de6dd07ca828914069cc1b86177303fd05c116 100644
--- a/chrome/browser/tab_contents/tab_contents_view_gtk.h
+++ b/chrome/browser/tab_contents/tab_contents_view_gtk.h
@@ -7,6 +7,8 @@
#include <gtk/gtk.h>
+#include <vector>
+
#include "base/scoped_ptr.h"
#include "chrome/browser/gtk/focus_store_gtk.h"
#include "chrome/browser/tab_contents/tab_contents_view.h"
@@ -15,6 +17,7 @@
#include "chrome/common/owned_widget_gtk.h"
class BlockedPopupContainerViewGtk;
+class ConstrainedWindowGtk;
class RenderViewContextMenuGtk;
class SadTabGtk;
typedef struct _GtkFloatingContainer GtkFloatingContainer;
@@ -33,6 +36,11 @@ class TabContentsViewGtk : public TabContentsView,
void AttachBlockedPopupView(BlockedPopupContainerViewGtk* popup_view);
void RemoveBlockedPopupView(BlockedPopupContainerViewGtk* popup_view);
+ // Unlike Windows, ConstrainedWindows need to collaborate with the
+ // TabContentsViewGtk to position the dialogs.
+ void AttachConstrainedWindow(ConstrainedWindowGtk* constrained_window);
+ void RemoveConstrainedWindow(ConstrainedWindowGtk* constrained_window);
+
// TabContentsView implementation --------------------------------------------
virtual void CreateView();
@@ -109,8 +117,14 @@ class TabContentsViewGtk : public TabContentsView,
FocusStoreGtk focus_store_;
+ // Our UI for controlling popups (or NULL if no popup windows have been
+ // opened). |popup_view_| is owned by the TabContents, not the view.
BlockedPopupContainerViewGtk* popup_view_;
+ // Each individual UI for constrained dialogs currently displayed. The
+ // objects in this vector are owned by the TabContents, not the view.
+ std::vector<ConstrainedWindowGtk*> constrained_windows_;
+
DISALLOW_COPY_AND_ASSIGN(TabContentsViewGtk);
};

Powered by Google App Engine
This is Rietveld 408576698