Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Unified Diff: chrome/browser/tab_contents/constrained_window.h

Issue 132047: GTK: HTTP Auth dialogs under linux. (Closed)
Patch Set: Fix for evanm Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/constrained_window.h
diff --git a/chrome/browser/tab_contents/constrained_window.h b/chrome/browser/tab_contents/constrained_window.h
index 35679a558bfa361a7863e6112b17ca058ca134ab..437f820bc99e670a5a919bca7eededef5aaf8626 100644
--- a/chrome/browser/tab_contents/constrained_window.h
+++ b/chrome/browser/tab_contents/constrained_window.h
@@ -8,16 +8,22 @@
#include "chrome/common/page_transition_types.h"
#include "webkit/glue/window_open_disposition.h"
-class ConstrainedWindow;
+// The different platform specific subclasses use different delegates for their
+// dialogs.
+#if defined(OS_WIN)
namespace views {
-class View;
class WindowDelegate;
}
-namespace gfx {
-class Point;
-class Rect;
-}
-class GURL;
+typedef views::WindowDelegate ConstrainedWindowDelegate;
+#elif defined(OS_LINUX)
+class ConstrainedWindowGtkDelegate;
+typedef ConstrainedWindowGtkDelegate ConstrainedWindowDelegate;
+#elif defined(OS_MACOSX)
+// TODO(port): Change this type when Mac gets ConstrainedWindows. It is here
+// only to make things compile. There is no user or consumer of this type.
+typedef void* ConstrainedWindowDelegate;
+#endif
+
class TabContents;
///////////////////////////////////////////////////////////////////////////////
@@ -28,18 +34,15 @@ class TabContents;
//
class ConstrainedWindow {
public:
- // Create a Constrained Window that contains a views::View subclass
- // that provides the client area. Typical uses include the HTTP Basic Auth
- // prompt. The caller must provide an object implementing
- // views::WindowDelegate so that the Constrained Window can be properly
- // configured. If |initial_bounds| is empty, the dialog will be centered
- // within the constraining TabContents.
+ // Create a Constrained Window that contains a platform specific client
+ // area. Typical uses include the HTTP Basic Auth prompt. The caller must
+ // provide a delegate to describe the content area and to respond to events.
static ConstrainedWindow* CreateConstrainedDialog(
TabContents* owner,
- views::WindowDelegate* window_delegate);
+ ConstrainedWindowDelegate* delegate);
// Closes the Constrained Window.
virtual void CloseConstrainedWindow() = 0;
};
-#endif // #ifndef CHROME_TAB_CONTENTS_BROWSER_CONSTRAINED_WINDOW_H_
+#endif // CHROME_BROWSER_TAB_CONTENTS_CONSTRAINED_WINDOW_H_

Powered by Google App Engine
This is Rietveld 408576698