Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1320453004: OOPIFs: Moving GetSerializedHtmlData...WithLocalLinks away from RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-link-gathering
Patch Set: Rebasing... Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 60f38fc7fb257d54a88515511625bd25755d3cbc..13b18cea67ccc3850e4f4b10cd0bee918295a96f 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -153,7 +153,6 @@
#include "third_party/WebKit/public/web/WebNetworkStateNotifier.h"
#include "third_party/WebKit/public/web/WebNodeList.h"
#include "third_party/WebKit/public/web/WebPageImportanceSignals.h"
-#include "third_party/WebKit/public/web/WebPageSerializer.h"
#include "third_party/WebKit/public/web/WebPlugin.h"
#include "third_party/WebKit/public/web/WebPluginAction.h"
#include "third_party/WebKit/public/web/WebPluginContainer.h"
@@ -245,8 +244,6 @@ using blink::WebMouseEvent;
using blink::WebNavigationPolicy;
using blink::WebNavigationType;
using blink::WebNode;
-using blink::WebPageSerializer;
-using blink::WebPageSerializerClient;
using blink::WebPeerConnection00Handler;
using blink::WebPeerConnection00HandlerClient;
using blink::WebPeerConnectionHandler;
@@ -1353,9 +1350,6 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_MediaPlayerActionAt, OnMediaPlayerActionAt)
IPC_MESSAGE_HANDLER(ViewMsg_PluginActionAt, OnPluginActionAt)
IPC_MESSAGE_HANDLER(ViewMsg_SetActive, OnSetActive)
- IPC_MESSAGE_HANDLER(
- ViewMsg_GetSerializedHtmlDataForCurrentPageWithLocalLinks,
- OnGetSerializedHtmlDataForCurrentPageWithLocalLinks)
IPC_MESSAGE_HANDLER(ViewMsg_ShowContextMenu, OnShowContextMenu)
// TODO(viettrungluu): Move to a separate message filter.
IPC_MESSAGE_HANDLER(ViewMsg_SetHistoryOffsetAndLength,
@@ -2193,19 +2187,6 @@ blink::WebString RenderViewImpl::acceptLanguages() {
return WebString::fromUTF8(renderer_preferences_.accept_languages);
}
-// blink::WebPageSerializerClient implementation ------------------------------
-
-void RenderViewImpl::didSerializeDataForFrame(
- const WebURL& frame_url,
- const WebCString& data,
- WebPageSerializerClient::PageSerializationStatus status) {
- Send(new ViewHostMsg_SendSerializedHtmlData(
- routing_id(),
- frame_url,
- data.data(),
- static_cast<int32>(status)));
-}
-
// RenderView implementation ---------------------------------------------------
bool RenderViewImpl::Send(IPC::Message* message) {
@@ -2782,27 +2763,6 @@ void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,
webview()->performPluginAction(action, location);
}
-void RenderViewImpl::OnGetSerializedHtmlDataForCurrentPageWithLocalLinks(
- const std::vector<GURL>& links,
- const std::vector<base::FilePath>& local_paths,
- const base::FilePath& local_directory_name) {
-
- // Convert std::vector of GURLs to WebVector<WebURL>
- WebVector<WebURL> weburl_links(links);
-
- // Convert std::vector of base::FilePath to WebVector<WebString>
- WebVector<WebString> webstring_paths(local_paths.size());
- for (size_t i = 0; i < local_paths.size(); i++)
- webstring_paths[i] = local_paths[i].AsUTF16Unsafe();
-
- WebPageSerializer::serialize(webview()->mainFrame()->toWebLocalFrame(),
- true,
- this,
- weburl_links,
- webstring_paths,
- local_directory_name.AsUTF16Unsafe());
-}
-
void RenderViewImpl::OnSuppressDialogsUntilSwapOut() {
// Don't show any more dialogs until we finish OnSwapOut.
suppress_dialogs_until_swap_out_ = true;
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698