Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: content/browser/download/save_file_manager.cc

Issue 1320453004: OOPIFs: Moving GetSerializedHtmlData...WithLocalLinks away from RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-link-gathering
Patch Set: Rebasing... Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/save_package.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_file_manager.cc
diff --git a/content/browser/download/save_file_manager.cc b/content/browser/download/save_file_manager.cc
index e9aa71c62ab2e8cacdcfd86724f07fe97313afea..14abb510e0c58568f105f68216af1d0f833aa126 100644
--- a/content/browser/download/save_file_manager.cc
+++ b/content/browser/download/save_file_manager.cc
@@ -272,9 +272,8 @@ void SaveFileManager::SaveFinished(int save_id,
SaveFileMap::iterator it = save_file_map_.find(save_id);
if (it != save_file_map_.end()) {
SaveFile* save_file = it->second;
- // This routine may be called twice for the same from from
- // SaveePackage::OnReceivedSerializedHtmlData, once for the file
- // itself, and once when all frames have been serialized.
+ // This routine may be called twice from the same SavePackage - once for the
+ // file itself, and once when all frames have been serialized.
// So we can't assert that the file is InProgress() here.
// TODO(rdsmith): Fix this logic and put the DCHECK below back in.
// DCHECK(save_file->InProgress());
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/save_package.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698