Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320443009: Cmake: fix to make linking work on Ubuntu (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cmake: fix to make linking work on Ubuntu Committed: https://skia.googlesource.com/skia/+/2a4a4219aa8b9a44358dbff5ff7c220950601387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M cmake/CMakeLists.txt View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
hal.canary
PTAL
5 years, 3 months ago (2015-09-01 16:57:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320443009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320443009/1
5 years, 3 months ago (2015-09-01 17:03:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 17:08:25 UTC) #6
mtklein
lgtm
5 years, 3 months ago (2015-09-01 17:11:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320443009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320443009/1
5 years, 3 months ago (2015-09-01 17:11:21 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 17:11:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2a4a4219aa8b9a44358dbff5ff7c220950601387

Powered by Google App Engine
This is Rietveld 408576698