Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1320443008: [test] Fix skipping slow tests. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Michael Hablich
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix skipping slow tests. TBR=hablich@chromium.org NOTRY=true Committed: https://crrev.com/390853482bad9aafeea1662e795383fc9861e32e Cr-Commit-Position: refs/heads/master@{#30511}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/mozilla/mozilla.status View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
TBR - this keeps the original outcomes - skip wherever the original is pass/fail
5 years, 3 months ago (2015-09-01 12:54:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320443008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320443008/20001
5 years, 3 months ago (2015-09-01 12:54:49 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 12:56:30 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/390853482bad9aafeea1662e795383fc9861e32e Cr-Commit-Position: refs/heads/master@{#30511}
5 years, 3 months ago (2015-09-01 12:56:41 UTC) #6
Michael Hablich
On 2015/09/01 12:54:40, Michael Achenbach wrote: > TBR - this keeps the original outcomes - ...
5 years, 3 months ago (2015-09-01 12:57:53 UTC) #7
Michael Achenbach
5 years, 3 months ago (2015-09-01 13:16:41 UTC) #8
Message was sent while issue was closed.
On 2015/09/01 12:57:53, Hablich wrote:
> On 2015/09/01 12:54:40, Michael Achenbach wrote:
> > TBR - this keeps the original outcomes - skip wherever the original is
> pass/fail
> 
> This means if the original outcome is PASS and the result is PASS or TIMEOUT
the
> test is green? If the result is FAILED the test is red, isn't it?
> 
> LGTM

With original I mean the test result as expected in the ALWAYS section in the
status file. If timeout isn't expected, a timeout result is a failure.

Powered by Google App Engine
This is Rietveld 408576698